Skip to content
This repository was archived by the owner on Mar 9, 2026. It is now read-only.

Commit 918d254

Browse files
roottoolclaude
andauthored
fix/docs: remove trailing colons from comments and documentation (#56)
Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
1 parent 5686c7a commit 918d254

13 files changed

Lines changed: 36 additions & 26 deletions

File tree

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,32 +37,32 @@
3737

3838
## Security & API Stability
3939

40-
**Security Impact:**
40+
**Security Impact**
4141

4242
- [ ] No impact on security (no changes to forbidden keys, prototype safety)
4343
- [ ] Reviewed against security rules in AGENTS.md
4444
- [ ] If security-related: Explain impact and mitigation
4545

46-
**API Contract:**
46+
**API Contract**
4747

4848
- [ ] No changes to public API (`parse` function signature, type definitions)
4949
- [ ] No breaking changes to `ParseResult`, `ParseIssue`, or `IssueCode`
5050
- [ ] If API change: Is this a breaking change? (Yes/No + explanation)
5151

52-
**Versioning:**
52+
**Versioning**
5353

5454
- [ ] Change is compatible with current v0.x versioning policy
5555
- [ ] If breaking change proposed: Justification for major version bump
5656

5757
## Testing
5858

59-
**Automated Checks:**
59+
**Automated Checks**
6060

6161
- [ ] TypeScript type checking passes (`bun run check:type:source`)
6262
- [ ] All tests pass (`bun run test`)
6363
- [ ] Build succeeds (`bun run build`)
6464

65-
**Additional Verification** (describe any manual testing, edge case verification, or integration testing):
65+
**Additional Verification** (describe any manual testing, edge case verification, or integration testing)
6666

6767
<!-- Describe tests added, updated, or manual verification performed. If none, explain why. -->
6868

AGENTS.md

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -217,3 +217,15 @@ If a change makes the parser:
217217
it likely violates the boundary.
218218

219219
When in doubt, reject the change.
220+
221+
---
222+
223+
## Agent Skills
224+
225+
The `boundary-validator` skill in `skills/boundary-validator/` provides structured
226+
validation guidance based on the rules in this document.
227+
228+
- **Claude Code**: Activates automatically during PR creation and code review.
229+
Invoke with `Review this code against boundary-validator rules`.
230+
- **Other agents**: Apply the validation patterns in `skills/boundary-validator/SKILL.md`
231+
when creating PRs, reviewing code, or implementing features.

CLAUDE.md

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,7 @@ When implementing features or reviewing code:
1313
## Agent Skills
1414

1515
The `boundary-validator` skill (`skills/boundary-validator/`) validates code changes against AGENTS.md design rules.
16-
17-
- **Triggers**: Automatically activates when creating PRs or requesting code reviews
18-
- **Coverage**: See AGENTS.md "Design rules" and "Security rules" sections
16+
See AGENTS.md for trigger conditions and usage across agents.
1917

2018
**Usage in Claude Code**:
2119

CONTRIBUTING.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ This document provides guidelines for contributing to this boundary-focused Form
88

99
## Before You Start
1010

11-
**Please read these documents carefully:**
11+
**Please read these documents carefully.**
1212

1313
1. **README.md**: Understand the design principles and what safe-formdata is (and isn't)
1414
2. **AGENTS.md**: Review the non-negotiable implementation rules
@@ -110,7 +110,7 @@ bun run test:coverage # View coverage report
110110

111111
### 4. Security Considerations
112112

113-
**Mandatory security rules** (AGENTS.md):
113+
**Mandatory security rules** (AGENTS.md)
114114

115115
- Use `Object.create(null)` for parsed data (no prototype)
116116
- Reject forbidden keys: `__proto__`, `constructor`, `prototype`
@@ -135,7 +135,7 @@ Before submitting a PR:
135135

136136
### PR Description
137137

138-
Include:
138+
Include the following.
139139

140140
1. **Problem**: What issue does this solve?
141141
2. **Solution**: How does this maintain the boundary?
@@ -144,7 +144,7 @@ Include:
144144

145145
### Review Process
146146

147-
PRs will be evaluated against:
147+
PRs will be evaluated against the following.
148148

149149
1. **Alignment with design principles** (README.md)
150150
2. **Compliance with technical rules** (AGENTS.md)

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -197,7 +197,7 @@ if (result.data !== null) {
197197
}
198198
```
199199

200-
**Key points**:
200+
**Key points**
201201

202202
- All values are `string | File` - no automatic type conversion
203203
- Use `data !== null` to check for success and narrow the type

SECURITY.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ and **public security discussion**.
3030

3131
### Private (Security Advisory)
3232

33-
Use **GitHub Security Advisories** for:
33+
Use **GitHub Security Advisories** for the following.
3434

3535
- Reproducible vulnerabilities
3636
- Exploit techniques or payloads
@@ -42,7 +42,7 @@ Use **GitHub Security Advisories** for:
4242

4343
### Public Issue
4444

45-
Public issues are appropriate only for:
45+
Public issues are appropriate only for the following.
4646

4747
- **Design-level security questions**
4848
- **Non-sensitive security concerns**
@@ -149,7 +149,7 @@ safe-formdata **assumes**:
149149

150150
## Disclosure Policy
151151

152-
Security reports are handled as follows:
152+
Security reports are handled as follows.
153153

154154
1. **Review**
155155
- Issues are evaluated against the security scope defined above

docs/PUBLISHING.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ Before creating a release PR, validate locally:
2020
bun run prepare:publish
2121
```
2222

23-
This runs:
23+
This runs the following steps.
2424

2525
1. TypeScript type checking (`check:type:source`)
2626
2. Test suite with coverage (`test:coverage`)

examples/03-error-handling.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ for (const issue of result.issues) {
3535
});
3636
}
3737

38-
// Typical handling pattern:
38+
// Typical handling pattern is as follows.
3939
// - log issues
4040
// - return HTTP 400
4141
// - show a validation error to the user

skills/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ This directory contains **Agent Skills** specific to the safe-formdata project.
44

55
## What are Agent Skills?
66

7-
Agent Skills are structured knowledge packages that agents like Claude Code can efficiently reference. Based on the implementation rules in AGENTS.md, they provide:
7+
Agent Skills are structured knowledge packages that agents like Claude Code can efficiently reference. Based on the implementation rules in AGENTS.md, they provide the following.
88

99
- **Automatic triggering**: Activates automatically during PR creation and code review
1010
- **Progressive disclosure**: Loads only necessary information incrementally
@@ -18,7 +18,7 @@ Performs code review based on boundary principles.
1818

1919
- **Purpose**: Automatically detect violations of safe-formdata's design principles
2020
- **Triggers**: PR creation, code review, post-implementation
21-
- **Validation items**:
21+
- **Validation items**
2222
- Key opacity (no array notation parsing, etc.)
2323
- No silent behavior (no merging, overwriting, etc.)
2424
- No inference or convenience features

skills/boundary-validator/SKILL.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ Review this code against boundary-validator rules
5555

5656
### Review Process
5757

58-
The skill will:
58+
The skill will do the following.
5959

6060
1. **Read the changed files** using the Read and Grep tools
6161
2. **Check for violations** against the four design rules
@@ -234,12 +234,12 @@ const data = Object.create(null); // Not {}
234234

235235
### API Contract
236236

237-
**IssueCode stability**:
237+
**IssueCode stability**
238238

239239
- No new IssueCode values without major version bump
240240
- Existing codes: `invalid_key`, `forbidden_key`, `duplicate_key`
241241

242-
**ParseResult type**:
242+
**ParseResult type**
243243

244244
- Must be a discriminated union
245245
- `data !== null` for type narrowing

0 commit comments

Comments
 (0)