Test/add cli tests#3129
Open
ielson wants to merge 4 commits into
Open
Conversation
Author
|
PR is ready for review, from the requested checks just couldn't check if the other workflows passes, because they are awaiting approval |
Member
|
CI kicked off! |
Author
|
hey @bmagyar I believe that the tests didn't pass before because my branch was outdated but I have merged the new changes on it. |
Author
|
@bmagyar friendly ping, can you kick the CI off again? |
72ca142 to
a113bd1
Compare
Signed-off-by: Daniel Mascarenhas <danmascandrade@gmail.com> Signed-off-by: Daniel Mascarenhas <daniel.mascarenhas@saipem.com>
Signed-off-by: Daniel Mascarenhas <danmascandrade@gmail.com> Signed-off-by: Daniel Mascarenhas <daniel.mascarenhas@saipem.com>
1b2e4f0 to
ac32bf1
Compare
christophfroehlich
requested changes
May 17, 2026
Member
christophfroehlich
left a comment
There was a problem hiding this comment.
Please have a look at the failing tests. All new tests are failing?
Pre-commit ones are obvious, all lyrical-testing and main-testing jobs succeed on the current master, the main ones are known to be failing currently.
2026-05-14T13:04:31.2891181Z test_ros2_controlcli_verbs.TestRos2ControlCliVerbs.test_cleanup_controller failed
2026-05-14T13:04:31.2892232Z test_ros2_controlcli_verbs.TestRos2ControlCliVerbs.test_list_controller_types failed
2026-05-14T13:04:31.2893156Z test_ros2_controlcli_verbs.TestRos2ControlCliVerbs.test_list_controllers failed
2026-05-14T13:04:31.2894052Z test_ros2_controlcli_verbs.TestRos2ControlCliVerbs.test_list_hardware_components failed
2026-05-14T13:04:31.2895005Z test_ros2_controlcli_verbs.TestRos2ControlCliVerbs.test_list_hardware_interfaces failed
2026-05-14T13:04:31.2896157Z test_ros2_controlcli_verbs.TestRos2ControlCliVerbs.test_load_controller failed
2026-05-14T13:04:31.2897243Z test_ros2_controlcli_verbs.TestRos2ControlCliVerbs.test_reload_controller_libraries_force_kill failed
2026-05-14T13:04:31.2898313Z test_ros2_controlcli_verbs.TestRos2ControlCliVerbs.test_set_controller_state failed
2026-05-14T13:04:31.2899250Z test_ros2_controlcli_verbs.TestRos2ControlCliVerbs.test_switch_controllers_best_effort failed
2026-05-14T13:04:31.2900416Z test_ros2_controlcli_verbs.TestRos2ControlCliVerbs.test_unload_controller failed
2026-05-14T13:04:31.2901321Z test_ros2_controlcli_verbs.TestRos2ControlCliVerbs.test_view_hardware_status failed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #357
Summary
Add tests for ros2 control CLI verbs under 'controller_manager/test', using the existing local controller_manager test setup instead of depending on ros2_control_demos.
The new tests cover CLI behavior for:
Files added:
Testing
Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:
To send us a pull request, please:
colcon testandpre-commit run(requires you to install pre-commit bypip3 install pre-commit)