Skip to content

Fix duplicate fallback controllers from the controller chain (backport #3108)#3327

Merged
christophfroehlich merged 1 commit into
kiltedfrom
mergify/bp/kilted/pr-3108
May 18, 2026
Merged

Fix duplicate fallback controllers from the controller chain (backport #3108)#3327
christophfroehlich merged 1 commit into
kiltedfrom
mergify/bp/kilted/pr-3108

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented May 18, 2026

Fixes: #3038


This is an automatic backport of pull request #3108 done by Mergify.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 18, 2026

Codecov Report

❌ Patch coverage is 96.72131% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.89%. Comparing base (d305b87) to head (752f477).

Files with missing lines Patch % Lines
...ontroller_manager/test/test_controller_manager.cpp 96.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           kilted    #3327      +/-   ##
==========================================
+ Coverage   88.87%   88.89%   +0.01%     
==========================================
  Files         160      160              
  Lines       19917    19977      +60     
  Branches     1624     1624              
==========================================
+ Hits        17701    17758      +57     
- Misses       1542     1545       +3     
  Partials      674      674              
Flag Coverage Δ
unittests 88.89% <96.72%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
controller_manager/src/controller_manager.cpp 75.97% <100.00%> (ø)
...ontroller_manager/test/test_controller_manager.cpp 93.18% <96.66%> (+0.14%) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich merged commit f229f6c into kilted May 18, 2026
15 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/kilted/pr-3108 branch May 18, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants