Add xy_goal_tolerance_buffer description for goal checkers#917
Open
C88-YQ wants to merge 4 commits into
Open
Conversation
Signed-off-by: C88-YQ <1409947012@qq.com>
8 tasks
SteveMacenski
approved these changes
May 19, 2026
mini-1235
reviewed
May 21, 2026
|
|
||
| The adaptive tolerance goal checker uses two underlying goal tolerances a fine and a coarse one. The fine tolerance is used to instantly trigger goal reached when the robot is close to the goal (functionally same as simple goal checker), while the coarse tolerance is used to trigger goal reached when the robot is further from the goal but is making no meaningful progress towards it (or not expected to). | ||
|
|
||
| The goal is cosidered reached when one of the following conditions is met: |
Collaborator
There was a problem hiding this comment.
I think we should also mention the stateful + xybuffer condition here
Author
There was a problem hiding this comment.
@SteveMacenski Thanks for the reminder. Since #6124 is still undergoing some changes, I’d prefer to wait until the behavior in that PR is finalized before updating this part of the doc.
Member
There was a problem hiding this comment.
OK! Check out the last update required and then you can update docs. I should be able to merge this once you update both!
Author
There was a problem hiding this comment.
@SteveMacenski @mini-1235
I’ve updated the docs! 😄
When you have a chance, could you please take another look?
|
Tick the box to add this pull request to the merge queue (same as
|
…nce_goal_checker Signed-off-by: C88-YQ <jyc12888@gmail.com>
Signed-off-by: C88-YQ <jyc12888@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points