Added base pre-commit hooks to include whitespace and eol checks.#657
Merged
SteveMacenski merged 1 commit intoros-navigation:masterfrom Mar 17, 2025
Merged
Conversation
leander-dsouza
force-pushed
the
precommit-neccesary-hooks
branch
from
d05d4b2 to
7fbdcde
Compare
Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
leander-dsouza
force-pushed
the
precommit-neccesary-hooks
branch
from
7fbdcde to
016d937
Compare
SteveMacenski
approved these changes
Mar 17, 2025
mini-1235
pushed a commit
to mini-1235/docs.nav2.org
that referenced
this pull request
Mar 21, 2025
…s-navigation#657) Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I have added the following hooks as part of the pre-commit:
end-of-file-fixermixed-line-endingtrailing-whitespaceThis prevents empty whitespace and additional newlines from registering as a separate commit during development.
Testing
The following changes have been verified using
make htmland opening the_build/html/index.htmlfile on a browser window.