Skip to content

Doc for backward blind#685

Merged
SteveMacenski merged 10 commits intoros-navigation:masterfrom
grupo-avispa:back_dock
May 16, 2025
Merged

Doc for backward blind#685
SteveMacenski merged 10 commits intoros-navigation:masterfrom
grupo-avispa:back_dock

Conversation

@ajtudela
Copy link
Copy Markdown
Contributor

No description provided.

ajtudela added 3 commits May 13, 2025 13:38
Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
Comment thread migration/Jazzy.rst Outdated
ajtudela and others added 4 commits May 16, 2025 09:56
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
Comment thread configuration/packages/configuring-docking-server.rst Outdated
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
@SteveMacenski
Copy link
Copy Markdown
Member

This branch has conflicts that must be resolved

Can you resolve :-)

ajtudela added 2 commits May 16, 2025 19:28
Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
@SteveMacenski
Copy link
Copy Markdown
Member


fix end of files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

Comment thread migration/Jazzy.rst
@ajtudela
Copy link
Copy Markdown
Contributor Author


fix end of files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook

Done!

@SteveMacenski
Copy link
Copy Markdown
Member

Thanks 😆

I'll merge this now but the main PR I'll wait on CI before merging just to sanity check -- but you can consider this done! did you want to backport this to the Humble version in the other repo?

@SteveMacenski SteveMacenski merged commit b0813bd into ros-navigation:master May 16, 2025
4 checks passed
@ajtudela
Copy link
Copy Markdown
Contributor Author

Thanks 😆

I'll merge this now but the main PR I'll wait on CI before merging just to sanity check -- but you can consider this done! did you want to backport this to the Humble version in the other repo?

Sure!

@ajtudela ajtudela deleted the back_dock branch May 19, 2025 07:46
@ajtudela
Copy link
Copy Markdown
Contributor Author

Thanks 😆

I'll merge this now but the main PR I'll wait on CI before merging just to sanity check -- but you can consider this done! did you want to backport this to the Humble version in the other repo?

In humble, the direction/backward parameter is still on the server side. How do you want to handle this?

@SteveMacenski
Copy link
Copy Markdown
Member

SteveMacenski commented May 19, 2025

Add the blind bit on the server side too I guess. Maybe we should have in the main version the same backporting warnings if the blind docking is set in the server rather than plugin for future migrations. We can just throw and require an update for this feature rather than trying to handle it for them automatically

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants