Skip to content

Fix dependabot pip errors#751

Closed
leander-dsouza wants to merge 2 commits intoros-navigation:masterfrom
leander-dsouza:fix-dependabot-pip-errors
Closed

Fix dependabot pip errors#751
leander-dsouza wants to merge 2 commits intoros-navigation:masterfrom
leander-dsouza:fix-dependabot-pip-errors

Conversation

@leander-dsouza
Copy link
Copy Markdown
Contributor

Description

  • Fixes the series of failed deployment builds primarily due to the ubuntu: focal image at CircleCI.
  • The dependencies have been bumped to ensure a clean build with the latest version of the libraries.
  • get_html_theme_path() and display_version are removed as they are deprecated with the new version of Sphinx.

Testing

The following changes have been verified using make html and opening the _build/html/index.html file in a browser window.

@leander-dsouza leander-dsouza force-pushed the fix-dependabot-pip-errors branch 2 times, most recently from 077a84a to c6cdb17 Compare August 5, 2025 19:07
Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
@leander-dsouza leander-dsouza force-pushed the fix-dependabot-pip-errors branch from c6cdb17 to defd176 Compare August 5, 2025 19:14
@leander-dsouza leander-dsouza marked this pull request as ready for review August 5, 2025 19:20
@SteveMacenski
Copy link
Copy Markdown
Member

SteveMacenski commented Aug 5, 2025

I do not want to generically update sphinx and other libraries automatically. There are formatting and other changes that can occur on those adjustments and we need to be able to QA those change before they're accepted. Unless there's a specific reason to update certain versions or libraries, I air to the side of status quo on the docs to make the maintainer overhead as small as possible so we can focus attention on the main project.

@leander-dsouza
Copy link
Copy Markdown
Contributor Author

Thank you for the feedback, Steve.
Yes, you are right that there are slight formatting changes with the updated libraries.

To reduce the maintainer overhead, I think I can revert the pip version checking of dependabot, as it checks the latest version of libraries, which only work with ubuntu:latest. Apologies for the oversight, as I can imagine the frustration of having a bunch of incompatible dependabot PRs appear at once.

Therefore, I can close this PR and make another to revert the Python changes in dependabot.

@SteveMacenski
Copy link
Copy Markdown
Member

OK! Sounds good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants