Skip to content

Add doc8 as a pre-commit hook#776

Merged
SteveMacenski merged 3 commits intoros-navigation:masterfrom
leander-dsouza:doc8-lint
Sep 25, 2025
Merged

Add doc8 as a pre-commit hook#776
SteveMacenski merged 3 commits intoros-navigation:masterfrom
leander-dsouza:doc8-lint

Conversation

@leander-dsouza
Copy link
Copy Markdown
Contributor

@leander-dsouza leander-dsouza commented Sep 23, 2025

Basic Info

Info Please fill out this column
Ticket(s) this relates to (not addresses) #775 #742

Description of contribution in a few bullet points

  • Added doc8 as a linting standard for checking .rst files. This is popularly used in conjunction with Sphinx websites to ensure their correctness.

  • The current ruleset has fixed the following issues with the repository:

    • Fixed invalid rst formatting, which handles malformed tables, language specification in code blocks, etc.
    • Removed Windows-style carriage returns, ensuring consistent formatting across files.
    • Ensured spaces formatting over tabs.

Describe how this change was tested

  • Performed linting validation using pre-commit run --all
  • A base sanity check was done by verifying the build using make html and opening the _build/html/index.html file in a browser window.

Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
@leander-dsouza leander-dsouza marked this pull request as ready for review September 23, 2025 21:47
@SteveMacenski
Copy link
Copy Markdown
Member

Enforced a line length 200 for developer readability (this does not affect the website).

Can we remove this one? Sentences are more expressive than code & I would really like to not overly burden contributors with styling that is unimportant for the website. The other items I agree would be great.

Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
@leander-dsouza
Copy link
Copy Markdown
Contributor Author

Enforced a line length 200 for developer readability (this does not affect the website).

Can we remove this one? Sentences are more expressive than code & I would really like to not overly burden contributors with styling that is unimportant for the website. The other items I agree would be great.

Yes, sure.
I have dropped the line-length rule and have enforced the rest.

Copy link
Copy Markdown
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM!

Comment thread setup_guides/index.rst
@SteveMacenski SteveMacenski merged commit 49af542 into ros-navigation:master Sep 25, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants