Skip to content

Added pull request template to facilitate standardized contributions.#779

Merged
SteveMacenski merged 1 commit intoros-navigation:masterfrom
leander-dsouza:pr-template
Sep 24, 2025
Merged

Added pull request template to facilitate standardized contributions.#779
SteveMacenski merged 1 commit intoros-navigation:masterfrom
leander-dsouza:pr-template

Conversation

@leander-dsouza
Copy link
Copy Markdown
Contributor

@leander-dsouza leander-dsouza commented Sep 24, 2025


Basic Info

Info Please fill out this column
Ticket(s) this addresses N/A
Does this PR contain AI-generated software? No

Description of contribution in a few bullet points

  • Added a PR template with a table linking the repositories' tickets, along with ros-navigation/navigation2 tickets for ease of contribution.
  • I have used the embedded template as a demonstration for this contribution for ease of review.

@leander-dsouza leander-dsouza marked this pull request as ready for review September 24, 2025 01:51
Comment thread .github/PULL_REQUEST_TEMPLATE.md Outdated
* Reorganised some sections for better clarity.
-->

## Description of how this change was tested
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not sure this section is really relevant for docs PRs.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, sure. I have removed the testing section in the template.

Comment thread .github/PULL_REQUEST_TEMPLATE.md Outdated
| Info | Please fill out this column |
| ------ | ----------- |
| Ticket(s) this addresses | (add tickets here #1 or N/A) |
| Nav2 Ticket(s) this addresses | (paste the link of ros-navigation/navigation2 PR here or N/A) |
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a field if generative AI was used in this contribution.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added it according to the template Nav2 uses.

Comment thread .github/PULL_REQUEST_TEMPLATE.md Outdated

| Info | Please fill out this column |
| ------ | ----------- |
| Ticket(s) this addresses | (add tickets here #1 or N/A) |
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think just having this and clarifying it could be a doc or Nav2 ticket depending on context.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have removed the Nav2 ticket field and specified in the description whether to include a Doc/Nav2 ticket.

Signed-off-by: Leander Stephen D'Souza <leanderdsouza1234@gmail.com>
@SteveMacenski SteveMacenski merged commit aea5e0e into ros-navigation:master Sep 24, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants