Parallel state transitions#794
Closed
jplapp wants to merge 2 commits intoros-navigation:masterfrom
Closed
Conversation
Signed-off-by: Johannes Plapp <johannes.plapp@logivations.com>
Signed-off-by: Johannes Plapp <johannes.plapp@logivations.com>
8 tasks
|
|
||
|
|
||
| Lifecycle Manager | ||
| ---------------- |
Member
There was a problem hiding this comment.
The -- line has to match the length of the header. Also, make this more descriptive about the specific change made
| Lifecycle Manager | ||
| ---------------- | ||
|
|
||
| `PR #5541 <https://github.com/ros-navigation/navigation2/pull/5541>`_ adds a new parallel_state_transitions parameter. This will process all state transitions in parallel which can speed up launch in systems with many lifecycle nodes. On a system with 14 lifecycle nodes, the time for activating them goes from 17 seconds to 2 seconds. |
Member
There was a problem hiding this comment.
Suggested change
| `PR #5541 <https://github.com/ros-navigation/navigation2/pull/5541>`_ adds a new parallel_state_transitions parameter. This will process all state transitions in parallel which can speed up launch in systems with many lifecycle nodes. On a system with 14 lifecycle nodes, the time for activating them goes from 17 seconds to 2 seconds. | |
| `PR #5541 <https://github.com/ros-navigation/navigation2/pull/5541>`_ adds a new parallel_state_transitions parameter. This will process all state transitions in parallel which can speed up launch in systems with many lifecycle nodes. |
Given that's not what we see with Nav2 itself (a custom system), I'd prefer to keep that out since that makes people think Nav2 itself takes 17 seconds to load, which isn't the case I don't think?
Author
|
closed as related PR was closed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
document parallel state transitions