-
Notifications
You must be signed in to change notification settings - Fork 262
Parallel state transitions #794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
jplapp
wants to merge
2
commits into
ros-navigation:master
from
logivations:parallel-state-transitions
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -433,3 +433,10 @@ This server allows the robot to follow and maintain a determined distance from a | |||||
| The information about Following Server parameters set-up could be found at :ref:`configuring_following_server` configuration guide. | ||||||
|
|
||||||
| The tutorial for the Following Server has been recently updated. For the latest instructions and examples, see :ref:`navigation2-dynamic-point-following`. | ||||||
|
|
||||||
|
|
||||||
|
|
||||||
| Lifecycle Manager | ||||||
| ---------------- | ||||||
|
|
||||||
| `PR #5541 <https://github.com/ros-navigation/navigation2/pull/5541>`_ adds a new parallel_state_transitions parameter. This will process all state transitions in parallel which can speed up launch in systems with many lifecycle nodes. On a system with 14 lifecycle nodes, the time for activating them goes from 17 seconds to 2 seconds. | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Given that's not what we see with Nav2 itself (a custom system), I'd prefer to keep that out since that makes people think Nav2 itself takes 17 seconds to load, which isn't the case I don't think? |
||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
--line has to match the length of the header. Also, make this more descriptive about the specific change made