Skip to content

Fix incorrect variables in documentation for Gazebo world and robot spawning #805

Merged
SteveMacenski merged 1 commit intoros-navigation:masterfrom
redwine-1:redwine-1-patch-1
Nov 15, 2025
Merged

Fix incorrect variables in documentation for Gazebo world and robot spawning #805
SteveMacenski merged 1 commit intoros-navigation:masterfrom
redwine-1:redwine-1-patch-1

Conversation

@redwine-1
Copy link
Copy Markdown
Contributor

Updated paths for Gazebo world and robot spawning.


Basic Info

Info Please fill out this column
Ticket(s) this addresses N/A
Does this PR contain AI-generated software? No

Description of contribution in a few bullet points

  • Updated the documentation section titled “Add these two variables, which are needed for starting the Gazebo world and spawning the robot”.
  • Previously, this section listed:
    default_model_path = os.path.join(pkg_share, 'src', 'description', 'sam_bot_description.sdf')
    default_rviz_config_path = os.path.join(pkg_share, 'rviz', 'config.rviz')
    However, these variables are not related to Gazebo world launching or robot spawning.
    They are already defined in an earlier section of the documentation.
  • Replaced them with the correct variables actually used for Gazebo world and robot spawning:
    ros_gz_sim_share = get_package_share_directory('ros_gz_sim')
    gz_spawn_model_launch_source = os.path.join(ros_gz_sim_share, "launch", "gz_spawn_model.launch.py")

Type of change

  • Documentation fix
  • New feature
  • Bug fix
  • Refactor

Updated paths for Gazebo world and robot spawning.

Signed-off-by: Muhtasim Redwan <38636634+redwine-1@users.noreply.github.com>
@SteveMacenski SteveMacenski merged commit c5cd3e9 into ros-navigation:master Nov 15, 2025
3 of 4 checks passed
@SteveMacenski
Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants