upgrade container based documentation build environment.#862
Conversation
Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com>
SteveMacenski
left a comment
SteveMacenski
left a comment
There was a problem hiding this comment.
I'll be honest that I don't use devcontainers nor plan to, so these are contributions from other users.
bind all NICs available in this host.
these scripts do not really things instead of giving the permission to git. but now nav2doc is created and bound to the working directory /doc, so this is not needed anymore. for the maintainability, i would suggest to remove them from here.
Do you think either of these changes would be controversial for any devcontainer users? If not, happy to merge. This seems sensible to me though (but I didn't test if the user removes the need for setting the directory as safe -- but I assume you did).
no worries. i do use devcontainer most likely, so i just came up with this PR to enable it. if you do not like this, we can just drop it. but if you take it, i can make sure that works without problems. (if you have issues, just sign me up 👍)
|
|
Sounds good! |
…ion#862) Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com> Signed-off-by: Jaerak Son <sjr9017@naver.com>
2 participants
Basic Info
Description of contribution in a few bullet points
This PR fixes the container based documentation build environment.