Skip to content

use ROS_DISTRO env value instead of <ros2-distro>.#863

Merged
SteveMacenski merged 2 commits intoros-navigation:masterfrom
fujitatomoya:use-ROS_DISTRO-env-value
Feb 9, 2026
Merged

use ROS_DISTRO env value instead of <ros2-distro>.#863
SteveMacenski merged 2 commits intoros-navigation:masterfrom
fujitatomoya:use-ROS_DISTRO-env-value

Conversation

@fujitatomoya
Copy link
Copy Markdown
Contributor


Basic Info

Info Please fill out this column
Ticket(s) this addresses N/A
Does this PR contain AI-generated software? No

Description of contribution in a few bullet points

Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com>
Copy link
Copy Markdown
Contributor Author

@fujitatomoya fujitatomoya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with $ROS_DISTRO env val, user do not need to replace <ros2-distro> every time. they can copy&paste the command to execute.

Copy link
Copy Markdown
Member

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ones I commented on I don't think that opt ros or the workspace has been sourced yet in the terminal for that section for the env var to render :( I think that needs to be added first then if you want to add this.

I appreciate the efforts though!

.. code-block:: shell

sudo apt install ros-<ros2-distro>-ros-gz
sudo apt install ros-$ROS_DISTRO-ros-gz
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has opt ros been sourced yet in this tutorial's terminal?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah that is true, that should be done in the 1st place.

Comment thread setup_guides/odom/setup_odom_gz_classic.rst
Comment thread setup_guides/odom/setup_robot_localization.rst
Comment thread setup_guides/sdf/setup_sdf.rst
Comment thread setup_guides/urdf/setup_urdf.rst
Comment thread tutorials/docs/camera_calibration.rst
Comment thread tutorials/docs/navigation2_on_real_turtlebot3.rst
Comment thread tutorials/docs/navigation2_with_slam.rst Outdated
Comment thread tutorials/docs/navigation2_with_stvl.rst Outdated
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
@SteveMacenski SteveMacenski merged commit bb02769 into ros-navigation:master Feb 9, 2026
6 checks passed
mach0312 pushed a commit to mach0312/docs.nav2.org that referenced this pull request Feb 12, 2026
* use ROS_DISTRO env value instead of <ros2-distro>.

Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com>

* make sure to source ROS 2 workspace setup script.

Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>

---------

Signed-off-by: Tomoya.Fujita <tomoya.fujita825@gmail.com>
Signed-off-by: Tomoya.Fujita <Tomoya.Fujita@sony.com>
Signed-off-by: Jaerak Son <sjr9017@naver.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants