fix: correct external detection rotation in opennav_docking#899
Merged
SteveMacenski merged 1 commit intoros-navigation:masterfrom Apr 9, 2026
Merged
Conversation
* replace tf2::Quaternion::setEuler() with tf2::Quaternion::setRPY() - setEuler(p, r, y) rotation order: Rz(y) -> Rx(r) -> Ry(p) - setRPY(r, p, y) rotation order: Rx(r) -> Ry(p) -> Rz(y) * the computed rotation remains the same in the following cases: - when yaw rotation equals 0.0, or - when roll and pitch rotations both equal 1.0 * non-default rotation that differs from the above cases will break Implements documentation for ros-navigation/navigation2#6047 Signed-off-by: Nikolaos Drosinos <nikolaos.drosinos@ocado.com>
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Implements documentation for ros-navigation/navigation2#6047