fix dwb linear granularity default#900
fix dwb linear granularity default#900EricoMeger wants to merge 1 commit intoros-navigation:masterfrom
Conversation
Signed-off-by: EricoMeger <ericomeger9@gmail.com>
9b28f78 to
8a63e43
Compare
| Type Default | ||
| ------ ------- | ||
| double 0.5 | ||
| double 0.05 |
There was a problem hiding this comment.
There was a problem hiding this comment.
I think I got kinda biased from my DWA experience, I should have double-checked to see if it was actually correct.
That said, this value seems a bit strange to me, I think this would be way too coarse for the trajectory samples. Can't really say its a typo though, since looking at the git history 0.5 is the default value since the initial implementation in 2018
I also don't think it would be right to change the config example, since it seems like DWB historically has been configured using 0.05 instead. See Humble, for example: https://github.com/ros-navigation/navigation2/blob/e9caa4287b99c17f4ff39fbf2315d4d82e78da93/nav2_bringup/params/nav2_params.yaml#L164
I'll be closing this one then, thanks for taking a look!
Basic Info
Description of contribution in a few bullet points