Skip to content

fix dwb linear granularity default #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
EricoMeger wants to merge 1 commit into from
Closed

fix dwb linear granularity default #900

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion configuration/packages/dwb-plugins/standard_traj_generator.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ Parameters
====== =======
Type Default
------ -------
double 0.5
double 0.05
Copy link
Copy Markdown
Member

@SteveMacenski SteveMacenski Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to me to be correct: https://github.com/ros-navigation/navigation2/blob/a65638d58e95bb71ab33f5441ec7022c4c7f984b/nav2_dwb_controller/dwb_plugins/src/standard_traj_generator.cpp#L72

Copy link
Copy Markdown
Contributor Author

@EricoMeger EricoMeger Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I got kinda biased from my DWA experience, I should have double-checked to see if it was actually correct.

That said, this value seems a bit strange to me, I think this would be way too coarse for the trajectory samples. Can't really say its a typo though, since looking at the git history 0.5 is the default value since the initial implementation in 2018

I also don't think it would be right to change the config example, since it seems like DWB historically has been configured using 0.05 instead. See Humble, for example: https://github.com/ros-navigation/navigation2/blob/e9caa4287b99c17f4ff39fbf2315d4d82e78da93/nav2_bringup/params/nav2_params.yaml#L164

I'll be closing this one then, thanks for taking a look!

====== =======

Description
Expand Down
Loading