Adaptive tolerance goal checker#910
Merged
SteveMacenski merged 5 commits intoros-navigation:masterfrom Apr 28, 2026
Merged
Conversation
Signed-off-by: David G <david.randommail1@gmail.com>
Contributor
Author
|
@tonynajjar I did notice that the Axis goal checker is missing its entry on the Plugins list so let me know if you want me to add it so it gets merged with this... Or maybe if it is not meant to be there let me know if I should remove mine as well :) |
Contributor
|
Would be great if you can add it! Thanks |
Signed-off-by: David G <david.randommail1@gmail.com>
Signed-off-by: David G <david.randommail1@gmail.com>
Contributor
Author
|
@tonynajjar Added. Please check if the description is ok and your name is correct 😆 |
tonynajjar
reviewed
Apr 28, 2026
| | | | of goal, without requiring | | ||
| | | | rotational convergence. | | ||
| +---------------------------------+------------------------+----------------------------------+ | ||
| | `AxisGoalChecker`_ | Tony Najjar | A plugin check whether robot | |
Contributor
There was a problem hiding this comment.
Could I please ask you to modify to "Guillaume Doisy & Tony Najjar" as he is the original creator, I just polished it. @doisyg
Thanks for taking care of this ❤️
Signed-off-by: David G <david.randommail1@gmail.com>
SteveMacenski
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
Added documentation for the all new and cool
AdaptiveToleranceGoalChecker. Followed structure fromAxisGoalCheckeras it also holds a graph and a python script to generate it.Added: