This repository was archived by the owner on Jul 10, 2025. It is now read-only.
gazebo_ros: Fix spawn_entity.py model removal binding#1475
Open
agoeckner wants to merge 2 commits into
Open
Conversation
…ion after broken binding.
Author
|
Tagging gazebo_ros maintainers @j-rivero and @chapulina. |
cottsay
reviewed
May 5, 2023
Fixes comment by @cottsay.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolved spawn_entity.py node shutdown issue preventing removal of model from simulation after broken binding.
Without this change, the spawn_entity node's context is destroyed before the deletion message can be sent.