This repository was archived by the owner on Jul 10, 2025. It is now read-only.
use split_arguments=True in launch files to support whitespace in arguments#1507
Open
wjwwood wants to merge 2 commits into
Open
use split_arguments=True in launch files to support whitespace in arguments#1507wjwwood wants to merge 2 commits into
wjwwood wants to merge 2 commits into
Conversation
Signed-off-by: William Woodall <william@osrfoundation.org>
Signed-off-by: William Woodall <william@osrfoundation.org>
scpeters
approved these changes
Sep 28, 2023
Member
scpeters
left a comment
scpeters
left a comment
There was a problem hiding this comment.
approved, pending the merge and release of ros2/launch#711
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue with using launch arguments/substitutions that contain whitespace with the gazebo launch files, must be merged after ros2/launch#711, and also see that pr for details on the issue.