Skip to content

Commit 6594571

Browse files
author
Tomoya Fujita
authored
avoid redundancy for extra build and test arguments. (#17)
* avoid redundancy for extra build and test arguments. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * revert extra colcon argument behavior. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> * parsing arcuments does not require github token. Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com> --------- Signed-off-by: Tomoya Fujita <Tomoya.Fujita@sony.com>
1 parent 551df8c commit 6594571

2 files changed

Lines changed: 7 additions & 5 deletions

File tree

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@ ros-ci-for-pr \
2626
--pulls ros2/rosbag2#654 \
2727
--packages rosbag2_cpp rosbag2_tests \
2828
--build \
29+
--colcon-build-args="--continue-on-error" \
2930
--comment
3031
```
3132

ros_github_scripts/ci_for_pr.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
import yaml
2525

2626
logging.basicConfig(level=logging.INFO)
27-
logger = logging.getLogger('')
27+
logger = logging.getLogger(__name__)
2828

2929
DEFAULT_JOB = 'ci_launcher'
3030
REPOS_URL = 'https://raw.githubusercontent.com/ros2/ros2/{}/ros2.repos'
@@ -317,10 +317,10 @@ def comment_results(
317317
for pull in pulls:
318318
logger.info(f'Posting info as comment on {pull.html_url}')
319319
pull.create_issue_comment(body=contents)
320-
logger.info('>>> AUTO-COMMENTED BELOW CONTENT ON ALL PRS <<<')
320+
print('\n>>> AUTO-COMMENTED BELOW CONTENT ON ALL PRS <<<')
321321
else:
322-
logger.info('>>>> COPY-PASTE BELOW CONTENT TO PRS <<<')
323-
logger.info(contents)
322+
print('\n>>> COPY-PASTE BELOW CONTENT TO PRS <<<')
323+
print(contents)
324324

325325

326326
def parse_args():
@@ -365,14 +365,15 @@ def parse_args():
365365

366366

367367
def main():
368+
parsed = parse_args()
369+
368370
github_access_token = os.environ.get('GITHUB_ACCESS_TOKEN')
369371
if not github_access_token:
370372
github_access_token = os.environ.get('GITHUB_TOKEN')
371373
if not github_access_token:
372374
panic('Neither environment variable GITHUB_ACCESS_TOKEN nor GITHUB_TOKEN are set')
373375
github_instance = Github(github_access_token)
374376

375-
parsed = parse_args()
376377
pull_texts = parsed.pulls
377378
if parsed.interactive:
378379
all_user_pulls = fetch_user_pulls(github_instance)

0 commit comments

Comments
 (0)