Adding in topic name to logging on IPC issues (#2706)

* Adding in topic name to logging on IPC issues

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Update test matching output logging

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* adding in single quotes

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

---------

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

Author: SteveMacenski

rclcpp/include/rclcpp/publisher.hpp

@@ -147,7 +147,6 @@ class Publisher : public PublisherBase
     const rclcpp::PublisherOptionsWithAllocator<AllocatorT> & options)
   {
     // Topic is unused for now.
-    (void)topic;
     (void)options;
 
     // If needed, setup intra process communication.
@@ -158,11 +157,13 @@ class Publisher : public PublisherBase
       // Register the publisher with the intra process manager.
       if (qos.history() != rclcpp::HistoryPolicy::KeepLast) {
         throw std::invalid_argument(
-                "intraprocess communication allowed only with keep last history qos policy");
+                "intraprocess communication on topic '" + topic +
+                "' allowed only with keep last history qos policy");
       }
       if (qos.depth() == 0) {
         throw std::invalid_argument(
-                "intraprocess communication is not allowed with a zero qos history depth value");
+                "intraprocess communication on topic '" + topic +
+                "' is not allowed with a zero qos history depth value");
       }
       if (qos.durability() == rclcpp::DurabilityPolicy::TransientLocal) {
         buffer_ = rclcpp::experimental::create_intra_process_buffer<

rclcpp/include/rclcpp/subscription.hpp

@@ -147,11 +147,13 @@ class Subscription : public SubscriptionBase
       auto qos_profile = get_actual_qos();
       if (qos_profile.history() != rclcpp::HistoryPolicy::KeepLast) {
         throw std::invalid_argument(
-                "intraprocess communication allowed only with keep last history qos policy");
+                "intraprocess communication on topic '" + topic_name +
+                "' allowed only with keep last history qos policy");
       }
       if (qos_profile.depth() == 0) {
         throw std::invalid_argument(
-                "intraprocess communication is not allowed with 0 depth qos policy");
+                "intraprocess communication on topic '" + topic_name +
+                "' is not allowed with 0 depth qos policy");
       }
 
       using SubscriptionIntraProcessT = rclcpp::experimental::SubscriptionIntraProcess<

rclcpp/test/rclcpp/test_publisher.cpp

@@ -436,7 +436,8 @@ TEST_F(TestPublisher, intra_process_publish_failures) {
     node->create_publisher<test_msgs::msg::Empty>(
       "topic", rclcpp::QoS(0), options),
     std::invalid_argument(
-      "intraprocess communication is not allowed with a zero qos history depth value"));
+      "intraprocess communication on topic 'topic' "
+      "is not allowed with a zero qos history depth value"));
 }
 
 TEST_F(TestPublisher, inter_process_publish_failures) {