Fix Python linking on osx

Tobias-Fischer · Tobias-Fischer · commit ab157fefbcbe · 2021-07-21T08:29:15.000+10:00
Signed-off-by: Tobias Fischer &lt;info@tobiasfischer.info&gt;
diff --git a/rclpy/CMakeLists.txt b/rclpy/CMakeLists.txt
@@ -126,10 +126,17 @@ add_library(rclpy_common SHARED
 )
 target_link_libraries(rclpy_common PUBLIC
   pybind11::pybind11
-  ${PYTHON_LIBRARIES}
   rcl::rcl
   rmw::rmw
 )
+
+if(NOT APPLE)
+  target_link_libraries(rclpy_common ${PYTHON_LIBRARIES})
+else()
+  set_target_properties(rclpy_common PROPERTIES
+                        LINK_FLAGS "-undefined dynamic_lookup")
+endif()
+
 target_include_directories(rclpy_common PUBLIC
   src/rclpy_common/include
 )

Original file line number	Diff line number	Diff line change
`@@ -126,10 +126,17 @@ add_library(rclpy_common SHARED`
`126`	`126`	`)`
`127`	`127`	`target_link_libraries(rclpy_common PUBLIC`
`128`	`128`	`pybind11::pybind11`
`129`		`- ${PYTHON_LIBRARIES}`
`130`	`129`	`rcl::rcl`
`131`	`130`	`rmw::rmw`
`132`	`131`	`)`
	`132`	`+`
	`133`	`+if(NOT APPLE)`
	`134`	`+ target_link_libraries(rclpy_common ${PYTHON_LIBRARIES})`
	`135`	`+else()`
	`136`	`+ set_target_properties(rclpy_common PROPERTIES`
	`137`	`+ LINK_FLAGS "-undefined dynamic_lookup")`
	`138`	`+endif()`
	`139`	`+`
`133`	`140`	`target_include_directories(rclpy_common PUBLIC`
`134`	`141`	`src/rclpy_common/include`
`135`	`142`	`)`