drop unnecessary command step#6794
Merged
Merged
Conversation
christophebedard
approved these changes
May 17, 2026
christophebedard
left a comment
christophebedard
left a comment
Member
There was a problem hiding this comment.
Makes sense, thanks for the PR. Rviz was added to the launch file in ros2/demos#574, so I'll backport this to Lyrical (only).
christophebedard
pushed a commit
that referenced
this pull request
May 17, 2026
fujitatomoya
approved these changes
May 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes a redundant RViz2 launch step. The launch with
ros2 launch dummy_robot_bringup dummy_robot_bringup_launch.pylaunches RViz2 window and users do not need to do this again. Remove the confusion posed by the mention.Fixes the point raised in ros2/lyrical_tutorial_party#2527
Did you use Generative AI?
No
Additional Information
NA