Skip to content

Update topic info verbose test for buffer backend output#1247

Open
nvcyc wants to merge 1 commit into
rollingfrom
nvcyc/buffer_backend_topic_info
Open

Update topic info verbose test for buffer backend output#1247
nvcyc wants to merge 1 commit into
rollingfrom
nvcyc/buffer_backend_topic_info

Conversation

@nvcyc

@nvcyc nvcyc commented Jun 23, 2026

Copy link
Copy Markdown

Description

Update the ros2 topic info -v CLI test expectation to include the new buffer backend line emitted in verbose endpoint output.

Is this user-facing behavior change?

Yes. While the change in this pull request is for a test case, the underlying changes in other relevant packages add rosidl buffer backend information for each endpoint in ros2 topic info -v.

Did you use Generative AI?

No.

Additional Information

Relevant issue: #1245

Signed-off-by: CY Chen <cyc@nvidia.com>
@mergify

mergify Bot commented Jun 23, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@jmachowinski

Copy link
Copy Markdown

@mjcarroll Does it make sense to run CI on this, or can we just merge ?

@nvcyc

nvcyc commented Jul 2, 2026

Copy link
Copy Markdown
Author

@jmachowinski I have CI tests running here which is currently failing. I'm checking and addressing the failures and will update in relevant PRs when passed before we consider merging them all together.

@jmachowinski

Copy link
Copy Markdown

@nvcyc are you using the ros-for-ci scripts ?
You can specify mutiple PRs spanning multiple repos at once, and the script will post the same CI run in all PRs.

@nvcyc

nvcyc commented Jul 3, 2026

Copy link
Copy Markdown
Author

Thanks for the hint. Yes, I'm using ros-ci-for-pr --branch nvcyc/buffer_backend_topic_info --pulls ros2/rmw_zenoh#988 --build --colcon-build-args="--continue-on-error" --comment.

I used --branch nvcyc/buffer_backend_topic_info and only made it post the result in one of the PRs (the rmw_zenoh one) to not spam relevant PRs with failed CI run posts while I'm addressing the CI failures. Will copy the results to all the relevant PRs for the records once it's green and ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants