Skip to content

Commit ea8289f

Browse files
authored
Fix missing or wrong colors and dim inlay hints (#112)
* fix missing or wrong colors * dim inlay hint * Dim `editorWhitespace.foreground`
1 parent 7970cd1 commit ea8289f

10 files changed

Lines changed: 107 additions & 107 deletions

changelog.md

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,16 @@
11
# Changelog
22

3+
## v2.13.1
4+
5+
- Increase `findMatchHighlightForeground` contrast
6+
- Dim inlay hint
7+
- Dim `editorWhitespace.foreground`
8+
- Fix `linkedEditingBackground` background (matching tag highlight)
9+
- Fix `selectionBackground` missing alpha
10+
- Fix missing `editorIndentGuide`
11+
12+
## v2.13.0
13+
314
- Update `input.background`
415

516
## v1.3.3

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "rose-pine",
3-
"version": "2.13.0",
3+
"version": "2.13.1",
44
"publisher": "mvllow",
55
"description": "All natural pine, faux fur and a bit of soho vibes for the classy minimalist",
66
"license": "MIT",

pinecone.config.js

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,11 @@ Object.keys(roles).map((role) => {
1313
}
1414

1515
// Add translucent variations.
16+
palette[`${role}/80`] = {
17+
main: colorish(currentRole.main.hex, 0.8),
18+
moon: colorish(currentRole.moon.hex, 0.8),
19+
dawn: colorish(currentRole.dawn.hex, 0.8),
20+
}
1621
palette[`${role}/50`] = {
1722
main: colorish(currentRole.main.hex, 0.5),
1823
moon: colorish(currentRole.moon.hex, 0.5),

themes/_pinecone-color-theme.json

Lines changed: 12 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -95,20 +95,20 @@
9595
"editor.findMatchBorder": "$gold/50",
9696
"editor.findMatchForeground": "$text",
9797
"editor.findMatchHighlightBackground": "$highlightHigh",
98-
"editor.findMatchHighlightForeground": "$text",
98+
"editor.findMatchHighlightForeground": "$text/80",
9999
"editor.findMatchHighlightBorder": "",
100100
"editor.findRangeHighlightBackground": "$highlightHigh",
101101
"editor.findRangeHighlightBorder": "$transparent",
102102
"editor.focusedStackFrameHighlightBackground": "$highlightMed",
103-
"editor.foldBackground": "$surface",
103+
"editor.foldBackground": "$highlightMed",
104104
"editor.foreground": "$text",
105105
"editor.hoverHighlightBackground": "$transparent",
106106
"editor.inactiveSelectionBackground": "$highlightLow",
107107
"editor.inlineValuesBackground": "$transparent",
108108
"editor.inlineValuesForeground": "$subtle",
109109
"editor.lineHighlightBackground": "$highlightLow",
110110
"editor.lineHighlightBorder": "$transparent",
111-
"editor.linkedEditingBackground": "$surface",
111+
"editor.linkedEditingBackground": "$highlightMed",
112112
"editor.rangeHighlightBackground": "$highlightLow",
113113
"editor.rangeHighlightBorder": "",
114114
"editor.selectionBackground": "$highlightMed",
@@ -175,17 +175,15 @@
175175
"editorHoverWidget.foreground": "$subtle",
176176
"editorHoverWidget.highlightForeground": "$text",
177177
"editorHoverWidget.statusBarBackground": "$transparent",
178-
"editorIndentGuide.activeBackground": "$muted",
179-
"editorIndentGuide.background": "$highlightHigh",
180178
"editorInfo.background": "",
181179
"editorInfo.border": "$overlay",
182180
"editorInfo.foreground": "$foam",
183-
"editorInlayHint.background": "$overlay",
184-
"editorInlayHint.foreground": "$subtle",
185-
"editorInlayHint.parameterBackground": "$overlay",
186-
"editorInlayHint.parameterForeground": "$iris",
187-
"editorInlayHint.typeBackground": "$overlay",
188-
"editorInlayHint.typeForeground": "$foam",
181+
"editorInlayHint.background": "$overlay/50",
182+
"editorInlayHint.foreground": "$subtle/50",
183+
"editorInlayHint.parameterBackground": "$overlay/50",
184+
"editorInlayHint.parameterForeground": "$iris/50",
185+
"editorInlayHint.typeBackground": "$overlay/50",
186+
"editorInlayHint.typeForeground": "$foam/50",
189187
"editorLightBulb.foreground": "$pine",
190188
"editorLightBulbAutoFix.foreground": "$primary",
191189
"editorLineNumber.activeForeground": "$text",
@@ -229,7 +227,7 @@
229227
"editorWarning.background": "",
230228
"editorWarning.border": "$transparent",
231229
"editorWarning.foreground": "$gold",
232-
"editorWhitespace.foreground": "$muted",
230+
"editorWhitespace.foreground": "$muted/50",
233231
"editorWidget.background": "$surface",
234232
"editorWidget.border": "$overlay",
235233
"editorWidget.foreground": "$subtle",
@@ -582,8 +580,6 @@
582580
"tree.tableColumnsBorder": "",
583581
"walkThrough.embeddedEditorBackground": "$base",
584582
"welcomePage.background": "$base",
585-
"welcomePage.buttonBackground": "$surface",
586-
"welcomePage.buttonHoverBackground": "$overlay",
587583
"welcomePage.progress.background": "",
588584
"welcomePage.progress.foreground": "",
589585
"welcomePage.tileBackground": "",
@@ -665,13 +661,13 @@
665661
"editorGroup.dropIntoPromptForeground": "",
666662
"editorGutter.commentGlyphForeground": "",
667663
"editorGutter.commentUnresolvedGlyphForeground": "",
668-
"editorIndentGuide.activeBackground1": "",
664+
"editorIndentGuide.activeBackground1": "$muted",
669665
"editorIndentGuide.activeBackground2": "",
670666
"editorIndentGuide.activeBackground3": "",
671667
"editorIndentGuide.activeBackground4": "",
672668
"editorIndentGuide.activeBackground5": "",
673669
"editorIndentGuide.activeBackground6": "",
674-
"editorIndentGuide.background1": "",
670+
"editorIndentGuide.background1": "$highlightHigh",
675671
"editorIndentGuide.background2": "",
676672
"editorIndentGuide.background3": "",
677673
"editorIndentGuide.background4": "",

themes/rose-pine-color-theme.json

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -73,19 +73,19 @@
7373
"editor.findMatchBorder": "#f6c17780",
7474
"editor.findMatchForeground": "#e0def4",
7575
"editor.findMatchHighlightBackground": "#6e6a8666",
76-
"editor.findMatchHighlightForeground": "#e0def4",
76+
"editor.findMatchHighlightForeground": "#e0def4cc",
7777
"editor.findRangeHighlightBackground": "#6e6a8666",
7878
"editor.findRangeHighlightBorder": "#0000",
7979
"editor.focusedStackFrameHighlightBackground": "#6e6a8633",
80-
"editor.foldBackground": "#1f1d2e",
80+
"editor.foldBackground": "#6e6a8633",
8181
"editor.foreground": "#e0def4",
8282
"editor.hoverHighlightBackground": "#0000",
8383
"editor.inactiveSelectionBackground": "#6e6a861a",
8484
"editor.inlineValuesBackground": "#0000",
8585
"editor.inlineValuesForeground": "#908caa",
8686
"editor.lineHighlightBackground": "#6e6a861a",
8787
"editor.lineHighlightBorder": "#0000",
88-
"editor.linkedEditingBackground": "#1f1d2e",
88+
"editor.linkedEditingBackground": "#6e6a8633",
8989
"editor.rangeHighlightBackground": "#6e6a861a",
9090
"editor.selectionBackground": "#6e6a8633",
9191
"editor.selectionForeground": "#e0def4",
@@ -148,16 +148,14 @@
148148
"editorHoverWidget.foreground": "#908caa",
149149
"editorHoverWidget.highlightForeground": "#e0def4",
150150
"editorHoverWidget.statusBarBackground": "#0000",
151-
"editorIndentGuide.activeBackground": "#6e6a86",
152-
"editorIndentGuide.background": "#6e6a8666",
153151
"editorInfo.border": "#26233a",
154152
"editorInfo.foreground": "#9ccfd8",
155-
"editorInlayHint.background": "#26233a",
156-
"editorInlayHint.foreground": "#908caa",
157-
"editorInlayHint.parameterBackground": "#26233a",
158-
"editorInlayHint.parameterForeground": "#c4a7e7",
159-
"editorInlayHint.typeBackground": "#26233a",
160-
"editorInlayHint.typeForeground": "#9ccfd8",
153+
"editorInlayHint.background": "#26233a80",
154+
"editorInlayHint.foreground": "#908caa80",
155+
"editorInlayHint.parameterBackground": "#26233a80",
156+
"editorInlayHint.parameterForeground": "#c4a7e780",
157+
"editorInlayHint.typeBackground": "#26233a80",
158+
"editorInlayHint.typeForeground": "#9ccfd880",
161159
"editorLightBulb.foreground": "#31748f",
162160
"editorLightBulbAutoFix.foreground": "#ebbcba",
163161
"editorLineNumber.activeForeground": "#e0def4",
@@ -200,7 +198,7 @@
200198
"editorUnnecessaryCode.opacity": "#e0def480",
201199
"editorWarning.border": "#0000",
202200
"editorWarning.foreground": "#f6c177",
203-
"editorWhitespace.foreground": "#6e6a86",
201+
"editorWhitespace.foreground": "#6e6a8680",
204202
"editorWidget.background": "#1f1d2e",
205203
"editorWidget.border": "#26233a",
206204
"editorWidget.foreground": "#908caa",
@@ -463,11 +461,11 @@
463461
"tree.indentGuidesStroke": "#908caa",
464462
"walkThrough.embeddedEditorBackground": "#191724",
465463
"welcomePage.background": "#191724",
466-
"welcomePage.buttonBackground": "#1f1d2e",
467-
"welcomePage.buttonHoverBackground": "#26233a",
468464
"widget.shadow": "#1f1d2e4d",
469465
"window.activeBorder": "#1f1d2e",
470-
"window.inactiveBorder": "#1f1d2e"
466+
"window.inactiveBorder": "#1f1d2e",
467+
"editorIndentGuide.activeBackground1": "#6e6a86",
468+
"editorIndentGuide.background1": "#6e6a8666"
471469
},
472470
"tokenColors": [
473471
{

themes/rose-pine-dawn-color-theme.json

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -73,19 +73,19 @@
7373
"editor.findMatchBorder": "#ea9d3480",
7474
"editor.findMatchForeground": "#575279",
7575
"editor.findMatchHighlightBackground": "#6e6a8626",
76-
"editor.findMatchHighlightForeground": "#575279",
76+
"editor.findMatchHighlightForeground": "#575279cc",
7777
"editor.findRangeHighlightBackground": "#6e6a8626",
7878
"editor.findRangeHighlightBorder": "#0000",
7979
"editor.focusedStackFrameHighlightBackground": "#6e6a8614",
80-
"editor.foldBackground": "#fffaf3",
80+
"editor.foldBackground": "#6e6a8614",
8181
"editor.foreground": "#575279",
8282
"editor.hoverHighlightBackground": "#0000",
8383
"editor.inactiveSelectionBackground": "#6e6a860d",
8484
"editor.inlineValuesBackground": "#0000",
8585
"editor.inlineValuesForeground": "#797593",
8686
"editor.lineHighlightBackground": "#6e6a860d",
8787
"editor.lineHighlightBorder": "#0000",
88-
"editor.linkedEditingBackground": "#fffaf3",
88+
"editor.linkedEditingBackground": "#6e6a8614",
8989
"editor.rangeHighlightBackground": "#6e6a860d",
9090
"editor.selectionBackground": "#6e6a8614",
9191
"editor.selectionForeground": "#575279",
@@ -148,16 +148,14 @@
148148
"editorHoverWidget.foreground": "#797593",
149149
"editorHoverWidget.highlightForeground": "#575279",
150150
"editorHoverWidget.statusBarBackground": "#0000",
151-
"editorIndentGuide.activeBackground": "#9893a5",
152-
"editorIndentGuide.background": "#6e6a8626",
153151
"editorInfo.border": "#f2e9e1",
154152
"editorInfo.foreground": "#56949f",
155-
"editorInlayHint.background": "#f2e9e1",
156-
"editorInlayHint.foreground": "#797593",
157-
"editorInlayHint.parameterBackground": "#f2e9e1",
158-
"editorInlayHint.parameterForeground": "#907aa9",
159-
"editorInlayHint.typeBackground": "#f2e9e1",
160-
"editorInlayHint.typeForeground": "#56949f",
153+
"editorInlayHint.background": "#f2e9e180",
154+
"editorInlayHint.foreground": "#79759380",
155+
"editorInlayHint.parameterBackground": "#f2e9e180",
156+
"editorInlayHint.parameterForeground": "#907aa980",
157+
"editorInlayHint.typeBackground": "#f2e9e180",
158+
"editorInlayHint.typeForeground": "#56949f80",
161159
"editorLightBulb.foreground": "#286983",
162160
"editorLightBulbAutoFix.foreground": "#d7827e",
163161
"editorLineNumber.activeForeground": "#575279",
@@ -200,7 +198,7 @@
200198
"editorUnnecessaryCode.opacity": "#57527980",
201199
"editorWarning.border": "#0000",
202200
"editorWarning.foreground": "#ea9d34",
203-
"editorWhitespace.foreground": "#9893a5",
201+
"editorWhitespace.foreground": "#9893a580",
204202
"editorWidget.background": "#fffaf3",
205203
"editorWidget.border": "#f2e9e1",
206204
"editorWidget.foreground": "#797593",
@@ -463,11 +461,11 @@
463461
"tree.indentGuidesStroke": "#797593",
464462
"walkThrough.embeddedEditorBackground": "#faf4ed",
465463
"welcomePage.background": "#faf4ed",
466-
"welcomePage.buttonBackground": "#fffaf3",
467-
"welcomePage.buttonHoverBackground": "#f2e9e1",
468464
"widget.shadow": "#fffaf34d",
469465
"window.activeBorder": "#fffaf3",
470-
"window.inactiveBorder": "#fffaf3"
466+
"window.inactiveBorder": "#fffaf3",
467+
"editorIndentGuide.activeBackground1": "#9893a5",
468+
"editorIndentGuide.background1": "#6e6a8626"
471469
},
472470
"tokenColors": [
473471
{

themes/rose-pine-dawn-no-italics-color-theme.json

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -73,19 +73,19 @@
7373
"editor.findMatchBorder": "#ea9d3480",
7474
"editor.findMatchForeground": "#575279",
7575
"editor.findMatchHighlightBackground": "#6e6a8626",
76-
"editor.findMatchHighlightForeground": "#575279",
76+
"editor.findMatchHighlightForeground": "#575279cc",
7777
"editor.findRangeHighlightBackground": "#6e6a8626",
7878
"editor.findRangeHighlightBorder": "#0000",
7979
"editor.focusedStackFrameHighlightBackground": "#6e6a8614",
80-
"editor.foldBackground": "#fffaf3",
80+
"editor.foldBackground": "#6e6a8614",
8181
"editor.foreground": "#575279",
8282
"editor.hoverHighlightBackground": "#0000",
8383
"editor.inactiveSelectionBackground": "#6e6a860d",
8484
"editor.inlineValuesBackground": "#0000",
8585
"editor.inlineValuesForeground": "#797593",
8686
"editor.lineHighlightBackground": "#6e6a860d",
8787
"editor.lineHighlightBorder": "#0000",
88-
"editor.linkedEditingBackground": "#fffaf3",
88+
"editor.linkedEditingBackground": "#6e6a8614",
8989
"editor.rangeHighlightBackground": "#6e6a860d",
9090
"editor.selectionBackground": "#6e6a8614",
9191
"editor.selectionForeground": "#575279",
@@ -148,16 +148,14 @@
148148
"editorHoverWidget.foreground": "#797593",
149149
"editorHoverWidget.highlightForeground": "#575279",
150150
"editorHoverWidget.statusBarBackground": "#0000",
151-
"editorIndentGuide.activeBackground": "#9893a5",
152-
"editorIndentGuide.background": "#6e6a8626",
153151
"editorInfo.border": "#f2e9e1",
154152
"editorInfo.foreground": "#56949f",
155-
"editorInlayHint.background": "#f2e9e1",
156-
"editorInlayHint.foreground": "#797593",
157-
"editorInlayHint.parameterBackground": "#f2e9e1",
158-
"editorInlayHint.parameterForeground": "#907aa9",
159-
"editorInlayHint.typeBackground": "#f2e9e1",
160-
"editorInlayHint.typeForeground": "#56949f",
153+
"editorInlayHint.background": "#f2e9e180",
154+
"editorInlayHint.foreground": "#79759380",
155+
"editorInlayHint.parameterBackground": "#f2e9e180",
156+
"editorInlayHint.parameterForeground": "#907aa980",
157+
"editorInlayHint.typeBackground": "#f2e9e180",
158+
"editorInlayHint.typeForeground": "#56949f80",
161159
"editorLightBulb.foreground": "#286983",
162160
"editorLightBulbAutoFix.foreground": "#d7827e",
163161
"editorLineNumber.activeForeground": "#575279",
@@ -200,7 +198,7 @@
200198
"editorUnnecessaryCode.opacity": "#57527980",
201199
"editorWarning.border": "#0000",
202200
"editorWarning.foreground": "#ea9d34",
203-
"editorWhitespace.foreground": "#9893a5",
201+
"editorWhitespace.foreground": "#9893a580",
204202
"editorWidget.background": "#fffaf3",
205203
"editorWidget.border": "#f2e9e1",
206204
"editorWidget.foreground": "#797593",
@@ -463,11 +461,11 @@
463461
"tree.indentGuidesStroke": "#797593",
464462
"walkThrough.embeddedEditorBackground": "#faf4ed",
465463
"welcomePage.background": "#faf4ed",
466-
"welcomePage.buttonBackground": "#fffaf3",
467-
"welcomePage.buttonHoverBackground": "#f2e9e1",
468464
"widget.shadow": "#fffaf34d",
469465
"window.activeBorder": "#fffaf3",
470-
"window.inactiveBorder": "#fffaf3"
466+
"window.inactiveBorder": "#fffaf3",
467+
"editorIndentGuide.activeBackground1": "#9893a5",
468+
"editorIndentGuide.background1": "#6e6a8626"
471469
},
472470
"tokenColors": [
473471
{

themes/rose-pine-moon-color-theme.json

Lines changed: 13 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -73,19 +73,19 @@
7373
"editor.findMatchBorder": "#f6c17780",
7474
"editor.findMatchForeground": "#e0def4",
7575
"editor.findMatchHighlightBackground": "#817c9c4d",
76-
"editor.findMatchHighlightForeground": "#e0def4",
76+
"editor.findMatchHighlightForeground": "#e0def4cc",
7777
"editor.findRangeHighlightBackground": "#817c9c4d",
7878
"editor.findRangeHighlightBorder": "#0000",
7979
"editor.focusedStackFrameHighlightBackground": "#817c9c26",
80-
"editor.foldBackground": "#2a273f",
80+
"editor.foldBackground": "#817c9c26",
8181
"editor.foreground": "#e0def4",
8282
"editor.hoverHighlightBackground": "#0000",
8383
"editor.inactiveSelectionBackground": "#817c9c14",
8484
"editor.inlineValuesBackground": "#0000",
8585
"editor.inlineValuesForeground": "#908caa",
8686
"editor.lineHighlightBackground": "#817c9c14",
8787
"editor.lineHighlightBorder": "#0000",
88-
"editor.linkedEditingBackground": "#2a273f",
88+
"editor.linkedEditingBackground": "#817c9c26",
8989
"editor.rangeHighlightBackground": "#817c9c14",
9090
"editor.selectionBackground": "#817c9c26",
9191
"editor.selectionForeground": "#e0def4",
@@ -148,16 +148,14 @@
148148
"editorHoverWidget.foreground": "#908caa",
149149
"editorHoverWidget.highlightForeground": "#e0def4",
150150
"editorHoverWidget.statusBarBackground": "#0000",
151-
"editorIndentGuide.activeBackground": "#6e6a86",
152-
"editorIndentGuide.background": "#817c9c4d",
153151
"editorInfo.border": "#393552",
154152
"editorInfo.foreground": "#9ccfd8",
155-
"editorInlayHint.background": "#393552",
156-
"editorInlayHint.foreground": "#908caa",
157-
"editorInlayHint.parameterBackground": "#393552",
158-
"editorInlayHint.parameterForeground": "#c4a7e7",
159-
"editorInlayHint.typeBackground": "#393552",
160-
"editorInlayHint.typeForeground": "#9ccfd8",
153+
"editorInlayHint.background": "#39355280",
154+
"editorInlayHint.foreground": "#908caa80",
155+
"editorInlayHint.parameterBackground": "#39355280",
156+
"editorInlayHint.parameterForeground": "#c4a7e780",
157+
"editorInlayHint.typeBackground": "#39355280",
158+
"editorInlayHint.typeForeground": "#9ccfd880",
161159
"editorLightBulb.foreground": "#3e8fb0",
162160
"editorLightBulbAutoFix.foreground": "#ea9a97",
163161
"editorLineNumber.activeForeground": "#e0def4",
@@ -200,7 +198,7 @@
200198
"editorUnnecessaryCode.opacity": "#e0def480",
201199
"editorWarning.border": "#0000",
202200
"editorWarning.foreground": "#f6c177",
203-
"editorWhitespace.foreground": "#6e6a86",
201+
"editorWhitespace.foreground": "#6e6a8680",
204202
"editorWidget.background": "#2a273f",
205203
"editorWidget.border": "#393552",
206204
"editorWidget.foreground": "#908caa",
@@ -463,11 +461,11 @@
463461
"tree.indentGuidesStroke": "#908caa",
464462
"walkThrough.embeddedEditorBackground": "#232136",
465463
"welcomePage.background": "#232136",
466-
"welcomePage.buttonBackground": "#2a273f",
467-
"welcomePage.buttonHoverBackground": "#393552",
468464
"widget.shadow": "#2a273f4d",
469465
"window.activeBorder": "#2a273f",
470-
"window.inactiveBorder": "#2a273f"
466+
"window.inactiveBorder": "#2a273f",
467+
"editorIndentGuide.activeBackground1": "#6e6a86",
468+
"editorIndentGuide.background1": "#817c9c4d"
471469
},
472470
"tokenColors": [
473471
{

0 commit comments

Comments
 (0)