packets code clean up

Author: rossengeorgiev

aprslib/packets/__init__.py

@@ -1,2 +1,2 @@
-from aprslib.packets.position import PositionReport
-from aprslib.packets.telemetry import TelemetryReport
+from aprslib.packets.position import *
+from aprslib.packets.telemetry import *

aprslib/packets/base.py

@@ -5,9 +5,11 @@ class APRSPacket(object):
     format = 'raw'
     fromcall = 'N0CALL'
     tocall = 'N0CALL'
-    path = []
+    path = None
 
     def __init__(self, data=None):
+        self.path = []
+
         if data:
             self.load(data)
 

aprslib/packets/position.py

@@ -2,6 +2,10 @@
 from aprslib.packets.base import APRSPacket
 from aprslib.util import latitude_to_ddm, longitude_to_ddm, comment_altitude
 
+__all__ = [
+    'PositionReport',
+]
+
 
 class PositionReport(APRSPacket):
     format = 'uncompressed'

aprslib/packets/telemetry.py

@@ -1,13 +1,17 @@
 from aprslib.packets.base import APRSPacket
 
+__all__ = [
+    'TelemetryReport',
+]
+
 class TelemetryAddon(object):
     _analog_values = None
     _sequence_number = 0
     _digital_value = 0
 
 
     def __init__(self, *args, **kwargs):
-        self._analog_values = AnalogList()
+        self._analog_values = AnalogValueList()
         super(TelemetryAddon, self).__init__( *args, **kwargs)
 
     @property
@@ -21,7 +25,8 @@ def analog_values(self, v):
         if len(v) != 5:
             raise ValueError("Expected a list of 5 elements, got a list of %d" % len(v))
 
-        self._analog_values[:] = v
+        for i, elm in enumerate(v):
+            self._analog_values[i] = elm
 
     @property
     def sequence_number(self):
@@ -46,24 +51,12 @@ def digital_value(self, v):
             raise ValueError("Value outside of range 0-255")
 
 
-class AnalogList(list):
-    def __init__(self):
-        list.__init__(self, [0] * 5)
-
-    def __setitem__(self, i, v):
-        if not 0 <= i <= 4:
-            raise IndexError("Index outside of range 0-4, got %d" % i)
-        if not 0 <= v <= 999:
-            raise ValueError("Value outside of range 0-999, got %d" % v)
-        else:
-            list.__setitem__(self, i, v)
-
-    def __setslice__(self, i, j, v):
-        if i > j:
-            i, j = j, i
+class ImmutableList(list):
+    def __setitem__(self, a, b):
+        raise NotImplementedError("not supported")
 
-        for x in range(max(0, i), min(5, j)):
-            list.__setitem__(self, x, v[x])
+    def __setslice__(self, a, b, c):
+        raise NotImplementedError("not supported")
 
     def append(self, a):
         raise NotImplementedError("not supported")
@@ -81,11 +74,21 @@ def insert(self, a, b):
         raise NotImplementedError("not supported")
 
 
-class TelemetryReport(TelemetryAddon, APRSPacket):
-    @property
-    def format(self):
-        return 'telemetry'
+class AnalogValueList(ImmutableList):
+    def __init__(self):
+        list.__init__(self, [0] * 5)
+
+    def __setitem__(self, i, v):
+        if not 0 <= i <= 4:
+            raise IndexError("Index outside of range 0-4, got %d" % i)
+        if not 0 <= v <= 999:
+            raise ValueError("Value outside of range 0-999, got %d" % v)
+        else:
+            list.__setitem__(self, i, v)
+
 
+class TelemetryReport(TelemetryAddon, APRSPacket):
+    format = 'telemetry'
     _comment = ''
 
     @property