Account for missing binary bits

This patch updates the telemetry parsing to account for
missing binary bits in the packet.

Author: hemna

aprslib/parsing/telemetry.py

@@ -88,15 +88,20 @@ def parse_telemetry_config(body):
         elif form == "BITS":
             # APRS spec says 23 chars, but real-world packets may be longer
             # Accept any reasonable length (up to 100 chars to be safe)
+            # Some packets may be missing binary bits (just title)
             match = re.findall(r"^([01]{8}),(.{0,100})$", body.rstrip())
-            if not match:
-                raise ParseError("incorrect format of %s" % form)
-
-            bits, title = match[0]
-
-            parsed.update({
-                't%s' % form: bits,
-                'title': title.strip(' ')
+            if match:
+                bits, title = match[0]
+                parsed.update({
+                    't%s' % form: bits,
+                    'title': title.strip(' ')
+                })
+            else:
+                # No binary bits found - treat entire body as title
+                # This handles malformed packets like "BITS.title" without bits
+                parsed.update({
+                    't%s' % form: '00000000',  # Default to all zeros
+                    'title': body.rstrip().strip(' ')
                 })
 
     return (body, parsed)
@@ -138,9 +143,45 @@ def parse_telemetry_report(body):
     while len(analog_strs) < 5:
         analog_strs.append('')
 
-    # Digital I/O field (may be missing)
-    digital_field = parts[6] if len(parts) > 6 else '00000000'
-    comment = parts[7] if len(parts) > 7 else ''
+    # Digital I/O field (may be missing or in next position)
+    digital_field = parts[6] if len(parts) > 6 else ''
+    comment = ''
+    
+    # If digital field is empty, check if next field could be digital I/O
+    if not digital_field or digital_field.strip() == '':
+        if len(parts) > 7:
+            next_field = parts[7]
+            # Check if next field starts with binary digits (could be digital I/O with concatenated comment)
+            binary_match = re.match(r'^([01]+)', next_field)
+            if binary_match:
+                # Extract binary digits from start of next field
+                binary_str = binary_match.group(1)
+                # Use it as digital I/O if it's reasonable length (1-8 digits)
+                if len(binary_str) <= 8:
+                    digital_field = binary_str
+                    # Rest of next_field and remaining parts are comment
+                    remaining = next_field[len(binary_str):].lstrip(',')
+                    remaining_parts = [remaining] if remaining else []
+                    if len(parts) > 8:
+                        remaining_parts.extend(parts[8:])
+                    comment = ','.join(remaining_parts) if remaining_parts else ''
+                else:
+                    # Too long, use first 8 as digital I/O
+                    digital_field = binary_str[:8]
+                    remaining = binary_str[8:] + next_field[len(binary_str):]
+                    remaining_parts = [remaining] if remaining else []
+                    if len(parts) > 8:
+                        remaining_parts.extend(parts[8:])
+                    comment = ','.join(remaining_parts) if remaining_parts else ''
+            else:
+                # Next field is not binary, treat as comment
+                digital_field = '00000000'
+                comment = ','.join(parts[7:]) if len(parts) > 7 else ''
+        else:
+            # No more fields, use default
+            digital_field = '00000000'
+    else:
+        comment = ','.join(parts[7:]) if len(parts) > 7 else ''
 
     # Validate and parse sequence number (allow any positive integer)
     # APRS spec says 000-999, but real-world packets use larger numbers

tests/test_parse_telemetry.py

@@ -126,6 +126,18 @@ def test_valid_telemetry_minimal_packet(self):
         # Digital I/O should default to all zeros
         self.assertEqual(result['telemetry']['bits'], '00000000')
 
+    def test_valid_telemetry_missing_digital_with_binary_in_next(self):
+        """Test telemetry packet with missing digital I/O field, binary digits in next position"""
+        packet = "E25HML-13>APRS,TCPIP*,qAC,T2PERTH:T#075,039,,,000,000,,0000,ESP8266 Test WX DHT22 version"
+        result = parse(packet)
+
+        self.assertEqual(result['format'], 'telemetry')
+        self.assertEqual(result['telemetry']['seq'], 75)
+        self.assertEqual(result['telemetry']['vals'], [39.0, 0.0, 0.0, 0.0, 0.0])
+        # 0000 should be padded to 8 digits
+        self.assertEqual(result['telemetry']['bits'], '00000000')
+        self.assertEqual(result['comment'], 'ESP8266 Test WX DHT22 version')
+
     def test_valid_telemetry_empty_analog_value(self):
         """Test telemetry packet with empty analog value"""
         packet = "VU2IB-13>APRS,TCPIP*,qAC,T2DENMARK:T#126,250,057,000,040,,1011,Solar Power WX Station"

tests/test_parse_telemetry_config.py

@@ -108,6 +108,15 @@ def test_parse_telemetry_config_eqns(self):
         self.assertIsInstance(result['tEQNS'], list)
         self.assertEqual(len(result['tEQNS']), 5)
 
+    def test_bits_without_binary_bits(self):
+        """Test BITS telemetry config without binary bits (malformed packet)"""
+        packet = "E25HML-13>APRS,TCPIP*,qAC,T2PERTH::E25HML-13:BITS.ESP8266 Test WX DHT22 version"
+        result = parse(packet)
+
+        self.assertEqual(result['format'], 'telemetry-message')
+        self.assertEqual(result['tBITS'], '00000000')  # Default to all zeros
+        self.assertEqual(result['title'], 'ESP8266 Test WX DHT22 version')
+
 
 if __name__ == '__main__':
     unittest.main()