Replace deprecated datetime.utcnow() with datetime.now(timezone.utc)#95
Open
jelson wants to merge 1 commit into
Open
Replace deprecated datetime.utcnow() with datetime.now(timezone.utc)#95jelson wants to merge 1 commit into
jelson wants to merge 1 commit into
Conversation
datetime.utcnow() emits DeprecationWarning under Python 3.12+ and is scheduled for removal in a future version. Switch to the recommended timezone-aware alternative. Note: datetime.timezone is Python 3.2+, so this drops Python 2.7 support. Python 2.7 has been EOL since 2020.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
DeprecationWarningemitted on every parsed packet under Python 3.12+ fromaprslib/parsing/common.py:83.parse_timestamp's public output (int unix timestamp) is unchanged; the test was adjusted to use a tz-aware 1970 reference.Used
timezone.utcrather thandatetime.UTC(3.11+) for broader Python 3 support. This does drop Python 2.7, which has been EOL since 2020.pytest tests/test_parse_common.pypasses with no DeprecationWarning.