Fix/upgrade SQLite storage option

Author: rossnoah

pom.xml

@@ -152,6 +152,11 @@
             <artifactId>HikariCP</artifactId>
             <version>6.2.1</version>
         </dependency>
+        <dependency>
+            <groupId>org.xerial</groupId>
+            <artifactId>sqlite-jdbc</artifactId>
+            <version>3.47.1.0</version>
+        </dependency>
         <dependency>
             <groupId>com.squareup.okhttp</groupId>
             <artifactId>okhttp</artifactId>

src/main/java/dev/noah/perplayerkit/storage/StorageSelector.java

@@ -27,7 +27,6 @@
 
 public class StorageSelector {
 
-
     private StorageManager storageManager;
     private Plugin plugin;
 
@@ -39,7 +38,8 @@ public StorageSelector(Plugin plugin, String storageType) {
 
             case "yml":
             case "yaml":
-                storageManager = new YAMLStorage(plugin,plugin.getDataFolder() + File.separator + "please-use-a-real-database.yml");
+                storageManager = new YAMLStorage(plugin,
+                        plugin.getDataFolder() + File.separator + "please-use-a-real-database.yml");
                 break;
             case "redis":
                 storageManager = new RedisStorage(plugin);
@@ -50,8 +50,8 @@ public StorageSelector(Plugin plugin, String storageType) {
                 break;
             case "sqlite":
             default:
-                //default to sqlite
-                db = new SQLite(plugin.getDataFolder() + File.separator + "database.db");
+                // default to sqlite
+                db = new SQLite(plugin);
                 storageManager = new SQLStorage(db);
                 break;
         }
@@ -62,5 +62,4 @@ public StorageManager getDbManager() {
         return storageManager;
     }
 
-
 }

src/main/java/dev/noah/perplayerkit/storage/sql/SQLite.java

@@ -18,37 +18,88 @@
  */
 package dev.noah.perplayerkit.storage.sql;
 
+import com.zaxxer.hikari.HikariConfig;
+import com.zaxxer.hikari.HikariDataSource;
+import org.bukkit.plugin.Plugin;
+
+import java.io.File;
 import java.sql.Connection;
-import java.sql.DriverManager;
 import java.sql.SQLException;
 
 public class SQLite implements SQLDatabase {
 
+    private final Plugin plugin;
     private final String databasePath;
-    private Connection connection;
+    private HikariDataSource dataSource;
 
-    public SQLite(String databasePath) {
-        this.databasePath = databasePath;
+    public SQLite(Plugin plugin) {
+        this.plugin = plugin;
+        this.databasePath = plugin.getDataFolder() + File.separator + "database.db";
     }
 
     public boolean isConnected() {
-        try {
-            return connection != null && !connection.isClosed() && connection.isValid(1);
-        } catch (SQLException e) {
-            return false;
-        }
+        return (dataSource != null && !dataSource.isClosed());
     }
 
     public void connect() throws ClassNotFoundException, SQLException {
         if (!isConnected()) {
-            Class.forName("org.sqlite.JDBC");
-            connection = DriverManager.getConnection("jdbc:sqlite:" + databasePath);
+            // Ensure plugin data folder exists
+            plugin.getDataFolder().mkdirs();
+
+            HikariConfig config = new HikariConfig();
+
+            // Modern SQLite JDBC URL with optimized parameters (2025 best practices)
+            config.setJdbcUrl("jdbc:sqlite:" + databasePath +
+                    "?journal_mode=WAL" + // WAL mode for better concurrency
+                    "&synchronous=NORMAL" + // Balance between safety and performance
+                    "&cache_size=10000" + // 10MB cache (negative = KB, positive = pages)
+                    "&temp_store=MEMORY" + // Use memory for temp tables
+                    "&mmap_size=268435456" + // 256MB memory-mapped I/O
+                    "&optimize" + // Run PRAGMA optimize on connection
+                    "&foreign_keys=ON" + // Enable foreign key constraints
+                    "&busy_timeout=30000"); // 30 second busy timeout
+
+            config.setDriverClassName("org.sqlite.JDBC");
+            config.setPoolName("SQLite-Pool");
+
+            // SQLite-specific pool configuration (optimized for single-writer architecture)
+            config.setMaximumPoolSize(1); // SQLite is single-writer, use 1 connection
+            config.setMinimumIdle(1); // Keep one connection alive
+            config.setConnectionTimeout(30000); // 30 seconds connection timeout
+            config.setIdleTimeout(300000); // 5 minutes idle timeout (reduced from 10)
+            config.setMaxLifetime(1800000); // 30 minutes max connection lifetime
+            config.setLeakDetectionThreshold(60000); // 60 seconds leak detection
+            config.setKeepaliveTime(30000); // 30 seconds keepalive (HikariCP 4.0+)
+
+            // Modern HikariCP settings for better performance
+            config.setInitializationFailTimeout(10000); // 10 seconds initialization timeout
+            config.setValidationTimeout(5000); // 5 seconds validation timeout
+            config.setConnectionTestQuery("SELECT 1"); // Lightweight connection test
+            config.setAutoCommit(true); // SQLite default
+            config.setReadOnly(false); // Allow writes
+            config.setIsolateInternalQueries(false); // Don't isolate internal queries
+            config.setRegisterMbeans(false); // Disable JMX for performance
+            config.setAllowPoolSuspension(true); // Allow pool suspension for maintenance
+
+            // SQLite-specific connection properties (optimized for modern usage)
+            config.addDataSourceProperty("cachePrepStmts", "true");
+            config.addDataSourceProperty("prepStmtCacheSize", "500"); // Increased from 250
+            config.addDataSourceProperty("prepStmtCacheSqlLimit", "4096"); // Increased from 2048
+            config.addDataSourceProperty("useServerPrepStmts", "false"); // SQLite doesn't support server-side prepared
+                                                                         // statements
+            config.addDataSourceProperty("rewriteBatchedStatements", "true"); // Optimize batch operations
+            config.addDataSourceProperty("cacheResultSetMetadata", "true"); // Cache metadata for performance
+            config.addDataSourceProperty("cacheServerConfiguration", "true"); // Cache server config
+            config.addDataSourceProperty("elideSetAutoCommits", "true"); // Optimize auto-commit calls
+            config.addDataSourceProperty("maintainTimeStats", "false"); // Disable time stats for performance
+
+            dataSource = new HikariDataSource(config);
         }
     }
 
     public void disconnect() throws SQLException {
-        if (connection != null && !connection.isClosed()) {
-            connection.close();
+        if (isConnected()) {
+            dataSource.close();
         }
     }
 
@@ -60,6 +111,6 @@ public Connection getConnection() throws SQLException {
                 throw new SQLException("Failed to load SQLite driver", e);
             }
         }
-        return connection;
+        return dataSource.getConnection();
     }
 }