fix noisy tests

Author: rossnoah

pom.xml

@@ -13,6 +13,7 @@
 
     <properties>
         <java.version>1.8</java.version>
+        <mockito.version>5.15.2</mockito.version>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
     </properties>
 
@@ -56,6 +57,10 @@
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-resources-plugin</artifactId>
                 <version>3.3.1</version>
+                <configuration>
+                    <encoding>${project.build.sourceEncoding}</encoding>
+                    <propertiesEncoding>${project.build.sourceEncoding}</propertiesEncoding>
+                </configuration>
                 <executions>
                     <execution>
                         <id>process-resources</id>
@@ -78,6 +83,9 @@
                 <groupId>org.apache.maven.plugins</groupId>
                 <artifactId>maven-surefire-plugin</artifactId>
                 <version>3.5.2</version>
+                <configuration>
+                    <argLine>-javaagent:${settings.localRepository}/org/mockito/mockito-core/${mockito.version}/mockito-core-${mockito.version}.jar --enable-native-access=ALL-UNNAMED -Xshare:off</argLine>
+                </configuration>
             </plugin>
 
         </plugins>
@@ -183,7 +191,13 @@
         <dependency>
             <groupId>org.mockito</groupId>
             <artifactId>mockito-core</artifactId>
-            <version>5.15.2</version>
+            <version>${mockito.version}</version>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.slf4j</groupId>
+            <artifactId>slf4j-nop</artifactId>
+            <version>1.7.36</version>
             <scope>test</scope>
         </dependency>
         <dependency>

src/main/java/dev/noah/perplayerkit/storage/RedisStorage.java

@@ -18,7 +18,6 @@
  */
 package dev.noah.perplayerkit.storage;
 
-import dev.noah.perplayerkit.PerPlayerKit;
 import org.bukkit.plugin.Plugin;
 import redis.clients.jedis.Jedis;
 import redis.clients.jedis.JedisPool;
@@ -62,7 +61,7 @@ public boolean isConnected() {
         try (Jedis jedis = getConnection()) {
             return "PONG".equals(jedis.ping());
         } catch (Exception e) {
-            e.printStackTrace();
+            logRedisFailure("connectivity check", e);
             return false;
         }
     }
@@ -84,7 +83,7 @@ public void keepAlive() {
         try (Jedis jedis = getConnection()) {
             jedis.ping();
         } catch (Exception e) {
-            e.printStackTrace();
+            logRedisFailure("keepalive", e);
         }
     }
 
@@ -93,7 +92,7 @@ public void saveKitDataByID(String kitID, String data) {
         try (Jedis jedis = getConnection()) {
             jedis.set(kitID, data);
         } catch (Exception e) {
-            e.printStackTrace();
+            logRedisFailure("save operation for kit ID " + kitID, e);
         }
     }
 
@@ -103,7 +102,7 @@ public String getKitDataByID(String kitID) {
             String data = jedis.get(kitID);
             return data == null ? "Error" : data;
         } catch (Exception e) {
-            e.printStackTrace();
+            logRedisFailure("read operation for kit ID " + kitID, e);
             return "Error";
         }
     }
@@ -113,7 +112,7 @@ public boolean doesKitExistByID(String kitID) {
         try (Jedis jedis = getConnection()) {
             return jedis.exists(kitID);
         } catch (Exception e) {
-            e.printStackTrace();
+            logRedisFailure("existence check for kit ID " + kitID, e);
             return false;
         }
     }
@@ -123,7 +122,7 @@ public void deleteKitByID(String kitID) {
         try (Jedis jedis = getConnection()) {
             jedis.del(kitID);
         } catch (Exception e) {
-            e.printStackTrace();
+            logRedisFailure("delete operation for kit ID " + kitID, e);
         }
     }
 
@@ -140,8 +139,15 @@ public Set<String> getAllKitIDs() {
         try (Jedis jedis = getConnection()) {
             kitIDs.addAll(jedis.keys("*"));
         } catch (Exception e) {
-            e.printStackTrace();
+            logRedisFailure("list operation", e);
         }
         return kitIDs;
     }
+
+    private void logRedisFailure(String operation, Exception exception) {
+        if (plugin == null || plugin.getLogger() == null) {
+            return;
+        }
+        plugin.getLogger().fine("Redis " + operation + " failed: " + exception.getMessage());
+    }
 }

src/test/java/dev/noah/perplayerkit/storage/StorageMigratorTest.java

@@ -7,6 +7,8 @@
 
 import java.util.Arrays;
 import java.util.HashSet;
+import java.util.logging.Level;
+import java.util.logging.Logger;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertFalse;
@@ -24,7 +26,10 @@ class StorageMigratorTest {
     @BeforeEach
     void setUp() {
         plugin = mock(Plugin.class);
-        when(plugin.getLogger()).thenReturn(java.util.logging.Logger.getLogger("StorageMigratorTest"));
+        Logger logger = Logger.getLogger("StorageMigratorTest");
+        logger.setUseParentHandlers(false);
+        logger.setLevel(Level.OFF);
+        when(plugin.getLogger()).thenReturn(logger);
     }
 
     @Test

src/test/java/dev/noah/perplayerkit/storage/YAMLStorageTest.java

@@ -7,6 +7,8 @@
 
 import java.nio.file.Path;
 import java.util.Set;
+import java.util.logging.Level;
+import java.util.logging.Logger;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
 import static org.junit.jupiter.api.Assertions.assertFalse;
@@ -21,7 +23,10 @@ class YAMLStorageTest {
     @BeforeEach
     void setUp() {
         plugin = mock(Plugin.class);
-        when(plugin.getLogger()).thenReturn(java.util.logging.Logger.getLogger("YAMLStorageTest"));
+        Logger logger = Logger.getLogger("YAMLStorageTest");
+        logger.setUseParentHandlers(false);
+        logger.setLevel(Level.OFF);
+        when(plugin.getLogger()).thenReturn(logger);
     }
 
     @Test