Handle missing inspect names and tighten UUID resolution

- Reuse a single "player not found" path in inspect command handling
- Return null when a UUID cannot be mapped to a known name instead of showing the UUID
- Resolve identifiers via cached offline players first, then Mojang, without offline UUID fallback

Author: rossnoah

src/main/java/dev/noah/perplayerkit/commands/inspect/AbstractInspectCommand.java

@@ -95,12 +95,7 @@ public boolean onCommand(@NotNull CommandSender sender, @NotNull Command command
         CompletableFuture<Void> future = resolvePlayerIdentifierAsync(args[0])
                 .thenCompose(targetUuid -> {
                     if (targetUuid == null) {
-                        Bukkit.getScheduler().runTask(plugin, () -> {
-                            BroadcastManager.get().sendComponentMessage(player,
-                                    ERROR_PREFIX.append(
-                                            mm.deserialize("<red>Could not find a player with that name or UUID.</red>")));
-                            SoundManager.playFailure(player);
-                        });
+                        Bukkit.getScheduler().runTask(plugin, () -> showPlayerNotFound(player));
                         return CompletableFuture.completedFuture(null);
                     }
 
@@ -184,8 +179,20 @@ private void showInspectResult(Player inspector, UUID targetUuid, int slot) {
         }
 
         String targetName = getPlayerName(targetUuid);
+        if (targetName == null) {
+            showPlayerNotFound(inspector);
+            return;
+        }
+
         BroadcastManager.get().sendComponentMessage(inspector,
                 ERROR_PREFIX.append(mm.deserialize(missingDataMessage(targetName, slot))));
         SoundManager.playFailure(inspector);
     }
+
+    private void showPlayerNotFound(Player player) {
+        BroadcastManager.get().sendComponentMessage(player,
+                ERROR_PREFIX.append(
+                        mm.deserialize("<red>Could not find a player with that name or UUID.</red>")));
+        SoundManager.playFailure(player);
+    }
 }

src/main/java/dev/noah/perplayerkit/commands/inspect/InspectCommandUtil.java

@@ -31,7 +31,6 @@
 import org.jetbrains.annotations.Nullable;
 
 import java.io.IOException;
-import java.nio.charset.StandardCharsets;
 import java.util.UUID;
 import java.util.concurrent.CompletableFuture;
 
@@ -48,7 +47,7 @@ private InspectCommandUtil() {
     /**
      * Attempts to resolve a player identifier (name or UUID) to a UUID asynchronously.
      * This method first tries to parse as UUID, then checks online players synchronously,
-     * and finally searches offline players asynchronously.
+     * and finally searches cached offline players and Mojang asynchronously.
      *
      * @param identifier Player name or UUID string
      * @return CompletableFuture containing UUID if found, null otherwise
@@ -68,53 +67,30 @@ public static CompletableFuture<UUID> resolvePlayerIdentifierAsync(String identi
             return CompletableFuture.completedFuture(onlinePlayer.getUniqueId());
         }
 
-        // Look up UUID via Mojang API (avoids the very slow Bukkit.getOfflinePlayers() scan)
         return CompletableFuture.supplyAsync(() -> {
-            try {
-                OkHttpClient client = new OkHttpClient();
-                Request request = new Request.Builder()
-                        .url("https://api.mojang.com/users/profiles/minecraft/" + identifier)
-                        .build();
-                Response response = client.newCall(request).execute();
-                if (response.isSuccessful() && response.body() != null) {
-                    String body = response.body().string();
-                    // Parse the "id" field: {"id":"<uuid-no-dashes>","name":"<name>"}
-                    int idStart = body.indexOf("\"id\":\"") + 6;
-                    int idEnd = body.indexOf("\"", idStart);
-                    if (idStart > 5 && idEnd > idStart) {
-                        String raw = body.substring(idStart, idEnd);
-                        // Insert dashes into the 32-char UUID string
-                        String formatted = raw.substring(0, 8) + "-"
-                                + raw.substring(8, 12) + "-"
-                                + raw.substring(12, 16) + "-"
-                                + raw.substring(16, 20) + "-"
-                                + raw.substring(20);
-                        return UUID.fromString(formatted);
-                    }
-                }
-            } catch (IOException ignored) {
-                // Fall through to offline UUID computation
+            UUID cachedOfflinePlayer = findCachedOfflinePlayerUuid(identifier);
+            if (cachedOfflinePlayer != null) {
+                return cachedOfflinePlayer;
             }
-            // Fallback for offline/cracked-mode servers: compute deterministic offline UUID
-            return UUID.nameUUIDFromBytes(("OfflinePlayer:" + identifier).getBytes(StandardCharsets.UTF_8));
+
+            return lookupPlayerUuidFromMojang(identifier);
         });
     }
 
     /**
-     * Gets a player's name from their UUID, falling back to UUID string if name is not available.
+     * Gets a player's name from their UUID.
      *
      * @param uuid Player UUID
-     * @return Player name or UUID string
+     * @return Player name, or null if the UUID cannot be associated with a known player name
      */
-    public static String getPlayerName(@NotNull UUID uuid) {
+    public static @Nullable String getPlayerName(@NotNull UUID uuid) {
         Player onlinePlayer = Bukkit.getPlayer(uuid);
         if (onlinePlayer != null) {
             return onlinePlayer.getName();
         }
 
         OfflinePlayer offlinePlayer = Bukkit.getOfflinePlayer(uuid);
-        String name = offlinePlayer.getName();
-        return name != null ? name : uuid.toString();
+        return offlinePlayer.getName();
     }
 
     /**
@@ -128,4 +104,55 @@ public static void showUsage(@NotNull Player player, @NotNull String commandName
                 ERROR_PREFIX.append(
                         mm.deserialize("<red>Usage: /" + commandName + " <player|uuid> <slot></red>")));
     }
+
+    private static @Nullable UUID findCachedOfflinePlayerUuid(@NotNull String identifier) {
+        for (OfflinePlayer offlinePlayer : Bukkit.getOfflinePlayers()) {
+            String name = offlinePlayer.getName();
+            if (name != null && name.equalsIgnoreCase(identifier)) {
+                return offlinePlayer.getUniqueId();
+            }
+        }
+        return null;
+    }
+
+    private static @Nullable UUID lookupPlayerUuidFromMojang(@NotNull String identifier) {
+        try {
+            OkHttpClient client = new OkHttpClient();
+            Request request = new Request.Builder()
+                    .url("https://api.mojang.com/users/profiles/minecraft/" + identifier)
+                    .build();
+            Response response = client.newCall(request).execute();
+            try {
+                if (!response.isSuccessful() || response.body() == null) {
+                    return null;
+                }
+
+                String body = response.body().string();
+                int idStart = body.indexOf("\"id\":\"");
+                if (idStart < 0) {
+                    return null;
+                }
+
+                idStart += 6;
+                int idEnd = body.indexOf("\"", idStart);
+                if (idEnd <= idStart) {
+                    return null;
+                }
+
+                String raw = body.substring(idStart, idEnd);
+                String formatted = raw.substring(0, 8) + "-"
+                        + raw.substring(8, 12) + "-"
+                        + raw.substring(12, 16) + "-"
+                        + raw.substring(16, 20) + "-"
+                        + raw.substring(20);
+                return UUID.fromString(formatted);
+            } finally {
+                if (response.body() != null) {
+                    response.body().close();
+                }
+            }
+        } catch (IOException | IllegalArgumentException ignored) {
+            return null;
+        }
+    }
 }