Add option to disable sound#36
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughA global configuration toggle for plugin sounds was introduced, allowing all sounds to be enabled or disabled via a single setting. The SoundManager was updated to respect this flag, and documentation was added to describe the new configuration options, including detailed descriptions and examples for each sound event. Changes
Sequence Diagram(s)sequenceDiagram
participant Plugin
participant SoundManager
participant Config
participant Player
Plugin->>SoundManager: play(Player, Sound)
SoundManager->>Config: get("sounds.enabled", default=true)
alt sounds enabled
SoundManager->>Player: playSound(Sound)
else sounds disabled
SoundManager-->>Plugin: return (no sound)
end
Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (3)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Summary by CodeRabbit
New Features
Documentation