Commit 634f6d6
committed
docs(cpex): close remaining PR #493 review nits
Final sweep to ensure every Hai Huang comment is addressed:
- cpex-policy.yaml: add a DEMO ONLY banner — the file embeds hardcoded
client secrets (client_secret_source.kind: literal) over plaintext
http to a local Keycloak. Addresses the "kind: literal secrets want a
demo-only banner" nit (previously only realm-export.json was banner'd).
- cmf_a2a_test.go: TestA2AResponseBodyMod_RewritesArtifact now asserts
the ORIGINAL secret is absent after redaction, not just that the
redacted string is present (the reviewer's explicit ask — a partial
rewrite would satisfy presence-only).
- README.md: correct the OPA/PDP note — the demo DOES exercise the
embedded `cedar` PDP (scenario 05 → cpex.cedar_default_deny); only the
external `opa(...)` / `authzen(...)` steps are doc-level BYOP examples.
Signed-off-by: Frederico Araujo <frederico.araujo@ibm.com>1 parent 7da57be commit 634f6d6
3 files changed
Lines changed: 13 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
152 | 152 | | |
153 | 153 | | |
154 | 154 | | |
155 | | - | |
156 | | - | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
157 | 158 | | |
158 | 159 | | |
159 | 160 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
120 | 120 | | |
121 | 121 | | |
122 | 122 | | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
123 | 128 | | |
124 | 129 | | |
125 | 130 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
3 | 8 | | |
4 | 9 | | |
5 | 10 | | |
| |||
0 commit comments