Commit 642a90b
committed
Fix(abctl): keep the innermost exchange's corners in deeply-nested spans
A request/response pair nested three or more levels deep — e.g. a
tools/list pair inside an a2a message/stream span inside a long-lived
$transport/stream span — rendered "││" on both rows instead of "│┌" /
"│└", so the pair didn't read as connected. computeSpanGlyphs caps the
PHASE prefix at two levels and was picking the two WIDEST enclosing
spans, whose middle bars masked the row's own corner.
Pick the inner glyph from the row's NARROWEST containing span (its own
tightest exchange) instead of the second-widest, so an endpoint of a
deeply-nested pair always shows its ┌/└ corner. The outer glyph still
shows the broadest enclosing span for context. Adds a triple-nested
test case covering exactly this shape.
Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com>
Signed-off-by: Hai Huang <huang195@gmail.com>1 parent 6cc58fe commit 642a90b
2 files changed
Lines changed: 34 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
615 | 615 | | |
616 | 616 | | |
617 | 617 | | |
618 | | - | |
619 | | - | |
| 618 | + | |
| 619 | + | |
620 | 620 | | |
621 | 621 | | |
622 | 622 | | |
623 | 623 | | |
| 624 | + | |
| 625 | + | |
| 626 | + | |
| 627 | + | |
| 628 | + | |
| 629 | + | |
| 630 | + | |
| 631 | + | |
| 632 | + | |
624 | 633 | | |
625 | 634 | | |
626 | | - | |
| 635 | + | |
627 | 636 | | |
628 | 637 | | |
629 | 638 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
685 | 685 | | |
686 | 686 | | |
687 | 687 | | |
| 688 | + | |
| 689 | + | |
| 690 | + | |
| 691 | + | |
| 692 | + | |
| 693 | + | |
| 694 | + | |
| 695 | + | |
| 696 | + | |
| 697 | + | |
| 698 | + | |
| 699 | + | |
| 700 | + | |
| 701 | + | |
| 702 | + | |
| 703 | + | |
| 704 | + | |
| 705 | + | |
| 706 | + | |
| 707 | + | |
| 708 | + | |
| 709 | + | |
688 | 710 | | |
689 | 711 | | |
690 | 712 | | |
| |||
0 commit comments