Skip to content

Commit a20a645

Browse files
committed
Feat: Role-based scope gating for github-issue demo - addressing
mrsabath review comments Signed-off-by: Omer Boehm <omerboehm@gmail.com>
1 parent 40f2e58 commit a20a645

2 files changed

Lines changed: 6 additions & 5 deletions

File tree

authbridge/demos/github-issue/aiac/Makefile

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,12 +31,12 @@ help: ## Show this menu (default)
3131
$(MAKEFILE_LIST)
3232
@printf "\nVariables:\n"
3333
@printf " \033[36m%-20s\033[0m %s\n" "POLICY" "policy file to apply (default: policies/regular_policy.txt)"
34-
@printf " \033[36m%-20s\033[0m %s\n" "RBAC_CONFIG" "RBAC config file (default: config/rbac/rbac_config.yaml)"
34+
@printf " \033[36m%-20s\033[0m %s\n" "RBAC_CONFIG" "RBAC config file (default: rbac/config.yaml)"
3535
@printf " \033[36m%-20s\033[0m %s\n" "PYTHON" "Python interpreter (default: kagenti-extensions/.venv/bin/python)"
3636
@printf "\nPrerequisites: uv, Keycloak running, aiac.env and llm_conf.yaml configured.\n\n"
3737

3838
POLICY ?= policies/regular_policy.txt
39-
RBAC_CONFIG ?= ../rbac/config.yaml
39+
RBAC_CONFIG ?= rbac/config.yaml
4040

4141
# Resolve the venv relative to this Makefile, regardless of where make is invoked.
4242
MAKEFILE_DIR := $(dir $(abspath $(lastword $(MAKEFILE_LIST))))
@@ -83,7 +83,7 @@ preflight: ## Verify prerequisites (uv, venv, aiac.env, llm_conf.yaml, Keycloak
8383

8484
setup: preflight ## Provision Keycloak realm with clients, roles, and users
8585
@echo "[*] Provisioning Keycloak realm ..."
86-
$(PYTHON) ../setup_keycloak.py -rbac aiac/$(RBAC_CONFIG)
86+
$(PYTHON) ../setup_keycloak.py -rbac $(RBAC_CONFIG)
8787
@echo "[✓] Keycloak realm provisioned."
8888

8989
# ---------- Apply policy ----------
@@ -98,13 +98,13 @@ apply-permissive: apply-policy ## Generate + apply the permissive policy (grant
9898
# ---------- Show result ----------
9999

100100
show-result: preflight ## Show active composite-role mappings in Keycloak (verify applied policy)
101-
$(PYTHON) scripts/show-result.py --config-path $(RBAC_CONFIG)
101+
$(PYTHON) scripts/show-result.py --config-path ../$(RBAC_CONFIG)
102102

103103
# ---------- Reset ----------
104104

105105
reset: preflight ## Wipe generated configs and re-provision the realm from scratch
106106
@echo "[*] Removing generated configs ..."
107107
@rm -f config/*.yaml
108108
@echo "[*] Re-provisioning Keycloak realm ..."
109-
$(PYTHON) ../setup_keycloak.py -rbac aiac/$(RBAC_CONFIG)
109+
$(PYTHON) ../setup_keycloak.py -rbac $(RBAC_CONFIG)
110110
@echo "[✓] Reset complete."

authbridge/demos/github-issue/aiac/scripts/show-result.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ def main() -> None:
5151
parser.add_argument(
5252
"--config-path",
5353
type=Path,
54+
required=True,
5455
help="Path to the RBAC configuration YAML file",
5556
)
5657
args = parser.parse_args()

0 commit comments

Comments
 (0)