addressing PR review comments #492 (review)

omerboehm · omerboehm · commit c0b151cf5ce2 · 2026-06-18T20:34:52.000+03:00
Signed-off-by: Omer Boehm &lt;omerboehm@gmail.com&gt;
diff --git a/authbridge/demos/github-issue/aiac/aiac_agent/agent/__init__.py b/authbridge/demos/github-issue/aiac/aiac_agent/agent/__init__.py
@@ -19,5 +19,3 @@
     "create_policy_builder_graph",
     "PolicyState",
 ]
-
-# Made with Bob
diff --git a/authbridge/demos/github-issue/aiac/aiac_agent/agent/graph.py b/authbridge/demos/github-issue/aiac/aiac_agent/agent/graph.py
@@ -572,5 +572,3 @@ def save_policy(self, yaml_output: str, filepath: str = "access_control_policy.y
     print("Please use main.py to run the policy builder:")
     print("  python main.py <policy_file.txt> <config.yaml> <output_file.yaml>")
     sys.exit(1)
-
-# Made with Bob
diff --git a/authbridge/demos/github-issue/aiac/aiac_agent/agent/state.py b/authbridge/demos/github-issue/aiac/aiac_agent/agent/state.py
@@ -41,6 +41,3 @@ class PolicyState(TypedDict):
     errors: List[str]  # NOT accumulated - replaced on each validation attempt
     retry_count: int
     validation_passed: bool  # Boolean flag for retry decision, not accumulated
-
-
-# Made with Bob
diff --git a/authbridge/demos/github-issue/aiac/aiac_agent/config/__init__.py b/authbridge/demos/github-issue/aiac/aiac_agent/config/__init__.py
@@ -17,5 +17,3 @@
     "extract_realm_roles_and_clients",
     "MAX_VALIDATION_RETRIES",
 ]
-
-# Made with Bob
diff --git a/authbridge/demos/github-issue/aiac/aiac_agent/config/config_utils.py b/authbridge/demos/github-issue/aiac/aiac_agent/config/config_utils.py
@@ -102,6 +102,3 @@ def extract_realm_roles_and_clients(
     client_audience_targets = config.get("client_audience_targets", {})
 
     return realm_roles, client_roles_map, client_audience_targets
-
-
-# Made with Bob
diff --git a/authbridge/demos/github-issue/aiac/aiac_agent/config/constants.py b/authbridge/demos/github-issue/aiac/aiac_agent/config/constants.py
@@ -8,5 +8,3 @@
 # Maximum number of retry cycles from validate_policy back to parse_and_extract
 # This prevents infinite loops while allowing the LLM to self-correct
 MAX_VALIDATION_RETRIES = 3
-
-# Made with Bob
diff --git a/authbridge/demos/github-issue/aiac/aiac_agent/config/llm_config.py b/authbridge/demos/github-issue/aiac/aiac_agent/config/llm_config.py
@@ -285,6 +285,3 @@ def get_default_llm() -> BaseChatModel:
     if llm is None:
         llm = create_llm()
     return llm
-
-
-# Made with Bob
diff --git a/authbridge/demos/github-issue/aiac/aiac_agent/prompts/__init__.py b/authbridge/demos/github-issue/aiac/aiac_agent/prompts/__init__.py
@@ -13,5 +13,3 @@
     "build_system_prompt",
     "build_retry_prompt",
 ]
-
-# Made with Bob
diff --git a/authbridge/demos/github-issue/aiac/aiac_agent/prompts/prompt_builder.py b/authbridge/demos/github-issue/aiac/aiac_agent/prompts/prompt_builder.py
@@ -292,6 +292,3 @@ def build_retry_prompt(realm_roles: List[Dict[str, str]], client_roles_map: Dict
   }}
 ]
 ```"""
-
-
-# Made with Bob
diff --git a/authbridge/demos/github-issue/aiac/aiac_agent/utils/__init__.py b/authbridge/demos/github-issue/aiac/aiac_agent/utils/__init__.py
@@ -15,5 +15,3 @@
     "validate_policy_structure",
     "verify_policy_semantics",
 ]
-
-# Made with Bob
diff --git a/authbridge/demos/github-issue/aiac/aiac_agent/utils/parsers.py b/authbridge/demos/github-issue/aiac/aiac_agent/utils/parsers.py
@@ -116,6 +116,3 @@ def print_explanation(explanation: str, is_retry: bool = False, verbose: bool =
         print("=" * 80)
         print(explanation)
         print("=" * 80 + "\n")
-
-
-# Made with Bob
diff --git a/authbridge/demos/github-issue/aiac/aiac_agent/utils/validators.py b/authbridge/demos/github-issue/aiac/aiac_agent/utils/validators.py
@@ -286,6 +286,3 @@ def verify_policy_semantics(
         if "Already borrowed" in error_msg or "BadRequestError" in error_msg:
             return (False, False, "Verification skipped due to transient API error; retry required")
         return (False, False, f"Could not verify policy: {error_msg}")
-
-
-# Made with Bob
diff --git a/authbridge/demos/github-issue/aiac/config.yaml b/authbridge/demos/github-issue/aiac/config.yaml
@@ -3,7 +3,7 @@
 # Optional 'secret' parameter: if not provided, Keycloak will auto-generate the client secret
 clients:
   - client_id: "kagenti"
-    secret: "demo-ui-secret"
+    #secret: "demo-ui-secret-for-testing-do-not-use"
     direct_access_grants: true
     roles:
       - name: "demo-ui"
diff --git a/authbridge/demos/github-issue/aiac/keycloak_ops/export_config.py b/authbridge/demos/github-issue/aiac/keycloak_ops/export_config.py
@@ -359,4 +359,4 @@ def export_config(realm_name: str, output_file: str):
     print(f"  - {len(clients_config)} clients")
     print(f"  - {len(realm_roles)} realm roles")
     print(f"  - {len(users_config)} users")
-    print("\nYou can now use this file with setup_demo.py")
+    print("\nYou can now use this file with setup_keycloak.py -rbac")
diff --git a/authbridge/demos/github-issue/demo-aiac.md b/authbridge/demos/github-issue/demo-aiac.md
@@ -510,7 +510,7 @@ curl -s --max-time 300 \
 <sub><span style="color: gray; font-size: 0.9em;">
 Troubleshooting: \
 If INTERNAL_ID shows null, the Keycloak query didn't find the client. \
-Verify $ADMIN_TOKEN is not empty (Keycloak reachable?) and that setup_keycloak_aiac.py was run.
+Verify $ADMIN_TOKEN is not empty (Keycloak reachable?) and that setup_keycloak.py was run.
 </span></sub>
 
 <sub><span style="color: gray; font-size: 0.9em;">
@@ -858,5 +858,5 @@ To clean up and start fresh:
 rm -f generated_configs/*.yaml
 
 # re-provision the realm
-python setup_keycloak.py config.yaml
+python setup_keycloak.py -rbac config.yaml
 ```
diff --git a/authbridge/requirements.txt b/authbridge/requirements.txt
@@ -1,9 +1,9 @@
 python-keycloak>=7.1.1,<8
 PyYAML>=6.0.3
 
-langgraph>=0.2
-langchain-core>=0.2
-langchain-openai>=1.2
-pydantic>=2
+langgraph==1.2.5
+langchain-core==1.4.7
+langchain-openai==1.3.2
+pydantic==2.13.4
 
 python-dotenv>=1

Original file line number	Diff line number	Diff line change
`@@ -19,5 +19,3 @@`
`19`	`19`	`"create_policy_builder_graph",`
`20`	`20`	`"PolicyState",`
`21`	`21`	`]`
`22`		`-`
`23`		`-# Made with Bob`
Original file line number	Diff line number	Diff line change
`@@ -17,5 +17,3 @@`
`17`	`17`	`"extract_realm_roles_and_clients",`
`18`	`18`	`"MAX_VALIDATION_RETRIES",`
`19`	`19`	`]`
`20`		`-`
`21`		`-# Made with Bob`
Original file line number	Diff line number	Diff line change
`@@ -13,5 +13,3 @@`
`13`	`13`	`"build_system_prompt",`
`14`	`14`	`"build_retry_prompt",`
`15`	`15`	`]`
`16`		`-`
`17`		`-# Made with Bob`
Original file line number	Diff line number	Diff line change
`@@ -292,6 +292,3 @@ def build_retry_prompt(realm_roles: List[Dict[str, str]], client_roles_map: Dict`
`292`	`292`	`}}`
`293`	`293`	`]`
`294`	`294`	```"""
`295`		`-`
`296`		`-`
`297`		`-# Made with Bob`
Original file line number	Diff line number	Diff line change
`@@ -15,5 +15,3 @@`
`15`	`15`	`"validate_policy_structure",`
`16`	`16`	`"verify_policy_semantics",`
`17`	`17`	`]`
`18`		`-`
`19`		`-# Made with Bob`