Commit cae8cfe
committed
docs,fix: Address CodeRabbit review on transparent-proxy PR
- config: clarify TransparentProxyAddr doc — the proxy-sidecar/lite presets
default it to :8082 (always-on by design); empty only disables it for modes
without a preset default. Removes the misleading 'empty disables' claim that
the preset contradicts.
- transparentproxy.NewServer: guard against a nil ConnHandler (fall back to a
close-and-log handler) so a misconfiguration degrades to no-capture instead of
a dispatch-time panic.
- proxy-init README: list 'lite' alongside 'proxy-sidecar' in the mode table to
match the injection section.
Declined: SSH (port 22) exclusion for enforce-redirect. Excluding 22 would punch
a deliberate egress bypass hole, contradicting the fail-closed purpose; the
transparent listener blind-tunnels any TCP so captured SSH still works (unlike
redirect mode, which forwards to Envoy's HTTP listener — the reason it excludes
22). enforce-drop does not exclude 22 either.
Assisted-By: Claude (Anthropic AI) <noreply@anthropic.com>
Signed-off-by: Hai Huang <huang195@gmail.com>1 parent f884dc4 commit cae8cfe
3 files changed
Lines changed: 19 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
321 | 321 | | |
322 | 322 | | |
323 | 323 | | |
324 | | - | |
325 | | - | |
| 324 | + | |
| 325 | + | |
| 326 | + | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
326 | 331 | | |
327 | 332 | | |
328 | 333 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
34 | 34 | | |
35 | 35 | | |
36 | 36 | | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
37 | 47 | | |
38 | 48 | | |
39 | 49 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
8 | 8 | | |
9 | 9 | | |
10 | 10 | | |
11 | | - | |
12 | | - | |
| 11 | + | |
| 12 | + | |
13 | 13 | | |
14 | 14 | | |
15 | 15 | | |
| |||
0 commit comments