Skip to content

Commit 87b5941

Browse files
committed
Address review comments
Signed-off-by: Ed Snible <snible@us.ibm.com>
1 parent f9aa735 commit 87b5941

1 file changed

Lines changed: 16 additions & 5 deletions

File tree

  • a2a/a2a_currency_converter/deployment

a2a/a2a_currency_converter/deployment/k8s.yaml

Lines changed: 16 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ apiVersion: v1
1010
kind: Service
1111
metadata:
1212
labels:
13-
app.kubernetes.io/managed-by: kagenti-e2e
1413
app.kubernetes.io/name: a2a-currency-converter
1514
# kagenti.io/type=agent is required for the Agent to be discovered by Kagenti and show up in the UI
1615
kagenti.io/type: agent
@@ -34,7 +33,6 @@ kind: Deployment
3433
metadata:
3534
labels:
3635
app.kubernetes.io/component: agent
37-
app.kubernetes.io/managed-by: kagenti-e2e
3836
app.kubernetes.io/name: a2a-currency-converter
3937
kagenti.io/framework: LangGraph
4038
kagenti.io/type: agent
@@ -84,9 +82,21 @@ spec:
8482
# This is a dummy key; if using a real LLM API use a real key
8583
- name: LLM_API_KEY
8684
value: dummy
85+
# For production, use a Secret:
86+
# - name: OPENAI_API_KEY
87+
# valueFrom:
88+
# secretKeyRef:
89+
# name: llm-credentials
90+
# key: openai-api-key
8791
# This is a dummy key; if using OpenAI use a real key
8892
- name: OPENAI_API_KEY
8993
value: dummy
94+
# For production, use a Secret:
95+
# - name: OPENAI_API_KEY
96+
# valueFrom:
97+
# secretKeyRef:
98+
# name: llm-credentials
99+
# key: openai-api-key
90100
- name: LLM_MODEL
91101
value: llama3.2:3b-instruct-fp16
92102
- name: GITHUB_SECRET_NAME
@@ -128,12 +138,13 @@ spec:
128138
dnsPolicy: ClusterFirst
129139
restartPolicy: Always
130140
schedulerName: default-scheduler
131-
securityContext: {}
132141
serviceAccount: a2a-currency-converter
133142
serviceAccountName: a2a-currency-converter
134143
terminationGracePeriodSeconds: 30
144+
# This is for agents that use uv and its dependency cache
135145
volumes:
136146
- emptyDir: {}
137147
name: cache
138-
- emptyDir: {}
139-
name: marvin
148+
# Something like this is needed if the Agent has a Marvin dependency
149+
# - emptyDir: {}
150+
# name: marvin

0 commit comments

Comments
 (0)