Merge pull request #156 from rostilos/1.5.3-rc

rostilos · web-flow · commit 0a44dc4a2f0f · 2026-03-02T01:44:55.000+02:00
fix: Correct verification of incremental update failure in RagOperati…
diff --git a/java-ecosystem/libs/rag-engine/src/test/java/org/rostilos/codecrow/ragengine/service/RagOperationsServiceImplTest.java b/java-ecosystem/libs/rag-engine/src/test/java/org/rostilos/codecrow/ragengine/service/RagOperationsServiceImplTest.java
@@ -578,7 +578,9 @@ void testTriggerIncrementalUpdate_IncrementalUpdateThrows() throws Exception {
 
         service.triggerIncrementalUpdate(testProject, "feature", "c1", "diff", eventConsumer);
 
-        verify(ragIndexTrackingService).markIndexingFailed(eq(testProject), anyString());
+        // Should call markIncrementalUpdateFailed (keeps status INDEXED) NOT markIndexingFailed
+        verify(ragIndexTrackingService).markIncrementalUpdateFailed(eq(testProject), anyString());
+        verify(ragIndexTrackingService, never()).markIndexingFailed(any(), anyString());
         verify(analysisLockService).releaseLock("lock-key");
     }
 

Original file line number	Diff line number	Diff line change
`@@ -578,7 +578,9 @@ void testTriggerIncrementalUpdate_IncrementalUpdateThrows() throws Exception {`
`578`	`578`
`579`	`579`	`service.triggerIncrementalUpdate(testProject, "feature", "c1", "diff", eventConsumer);`
`580`	`580`
`581`		`- verify(ragIndexTrackingService).markIndexingFailed(eq(testProject), anyString());`
	`581`	`+ // Should call markIncrementalUpdateFailed (keeps status INDEXED) NOT markIndexingFailed`
	`582`	`+ verify(ragIndexTrackingService).markIncrementalUpdateFailed(eq(testProject), anyString());`
	`583`	`+ verify(ragIndexTrackingService, never()).markIndexingFailed(any(), anyString());`
`582`	`584`	`verify(analysisLockService).releaseLock("lock-key");`
`583`	`585`	`}`
`584`	`586`