Shortened code lines (partly using yapf), wrapped comments#38
Open
deeplook wants to merge 1 commit intorougier:masterfrom
Open
Shortened code lines (partly using yapf), wrapped comments#38deeplook wants to merge 1 commit intorougier:masterfrom
deeplook wants to merge 1 commit intorougier:masterfrom
Conversation
Owner
|
Looks good to me. |
Author
|
This is the respective PDF output with appropriate fonts: https://github.com/deeplook/numpy-100/blob/master/100%20Numpy%20exercises.pdf I feel like the MD parser needs to be more general to accommodate for cards showing arbitrary sequences of paragraphs and code, like in Jupyter notebooks. In fact, I had a go at this before with ReST and dedicated directives. I might give it another go. Would you be open to switching from MD to ReST? |
Owner
|
Not really but we can have a rst version alongside the md version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR mainly wraps comment lines manually, shortens code lines and applies some readability improvements mostly as suggested by
yapf. This helps generate a PDF version with index cards like in my fork. But as usual in such cases, the result is sometimes a bit of a compromise.