wishlist: make timeout on non-empty workdir configurable

[umlaeute]

while creating and re-creating my roundcube container (in the wake of #380 ) i got increasingly annoyed by the sleep time in

roundcubemail-docker/templates/docker-entrypoint.sh

Lines 40 to 43 in a0db4b1

	if [ "$(ls -A)" ]; then
	echo >&2 "WARNING: $PWD is not empty - press Ctrl+C now if this is an error!"
	( set -x; ls -A; sleep 10 )
	fi

I know that my /var/www/html is not empty, because i bind-mount my personal-skin to /var/www/html/skins/umlaeute, so there is no reason to make me wait whenever I create a new container.

I also understand that you might want to keep this sleep as a safeguard for misconfigurations.

so how about allowing the user to override the timeout?

like so:

( set -x; ls -A; sleep "${ROUNDCUBE_EMPTYWORKDIR_TIMEOUT:-10}" ) 

which allows me have ROUNDCUBE_EMPTYWORKDIR_TIMEOUT=0 in my .env file to just skip the sleep (obviously this could be improved, to not emit the "Press ^C to abort" if the timeout is 0; and whatnot)

[pabzm]

I'm open for a way to skip the workdir-non-empty-check entirely. Would you propose one?

Just changing the timeout value feels like patching a symptom, not the actual cause.

[pabzm]

Oh, and by the way: Yes, I think this is a good point and the change would be welcome!

[umlaeute]

right.

I see that being able to set the timeout is somewhat useless (the only practical nonstandard value I can imagine would be 0).

OTOH, the alternative would be just a boolean value (for which the only practical nonstandard value I can imagine would be 0 as well), so my thoughts were: why not allowing the user to set the timeout, just in case somebody does see a merit in that.

the third alternative would be, to just do away with the entire check (which would be fine by me, btw; but probably some people do want that safety measure).

the fourth alternative would be to only warn if there are actually conflicting files. and only wait in that case. I guess this would be the correct solution, but probably too complicated to implement.

[pabzm]

why not allowing the user to set the timeout, just in case somebody does see a merit in that.

I think the purpose of this new option would be to get rid of the check (because one knows that it will be triggered and uselessly delay the script) – just as your motivation is, too. Then the option should actually be a toggle to skip the check, not a way to shorten the time to wait. This would also avoid the log statements from the actual check if the directory is empty, which are ugly and maybe even misleading with a timeout of 0.

I would suggest to check if a given environment variable is set to anything at all ($var != ''), and to use a speaking name for that variable (e.g. SKIP_CHECK_EMPTY_DOCROOT), then its usage is pretty obvious.

(In principal I would prefer to have the check run non-interactively (meaning to exit the script if the check fails), since containers (mostly) aren't for interactive use, but I also don't want to break the published logic, so let's extend the functionality instead of breaking it.)