Zipdownload: fix escaping in Mbox downloads#10151
Open
gurnec wants to merge 3 commits into
Open
Conversation
gurnec
force-pushed
the
zipdownload-mbox
branch
2 times, most recently
from
7e9bc04 to
9ecb474
Compare
gurnec
force-pushed
the
zipdownload-mbox
branch
2 times, most recently
from
a965d1f to
0cad7a6
Compare
This checks an Mbox download has a properly escaped From line, and also checks at least some content of each zipped file (which as a side effect verifies the zips' CRCs).
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #10150.
This unfortunately adds some extra complication... a simpler alternative might be slurp each entire email into a variable and just
preg_replace()it all at once in_download_messages(). That would add additional memory overhead though.