Elastic: improve extensability of hover menu#10239
Open
johndoh wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
The failing coding style check is not related to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I know I could do this with a plugin and the
skin-message-list-hover-menu-initandskin-message-list-hover-menuhooks but the only visible effect of this change is to swap the delete and flag icons around (so that hover menu, or no hover menu, the flag stays in one place).with these changes then using only custom styling in
_styles.lessits possible to customise the menu quite a lot more than currently.flagged/deletedclass to the menu - allows for the text colour to change like it does on the row itself to reflect the status of the messagedateandsizetext spans populated allows both bits of information to be displayed if requiredin the example above the date is no longer obscured during hover and both the date and size are visible