Commit ca61338
committed
fix(translator): preserve typed Anthropic server tools through full conversion
Addresses the follow-up Codex review on PR #3804. The normalizer already
left typed Anthropic server tools (e.g. web_search_20250305) untouched, but
the downstream tool mapper in ConvertOpenAIRequestToClaude only emitted
type=="function" tools, silently dropping typed server tools from the final
Claude request when sent alongside a bare custom tool.
Pass typed server tools (type present, not "function") through verbatim into
the Claude tools array. Add TestConvertOpenAIRequestToClaude_TypedServerToolPreserved
to assert end-to-end survival through the full conversion, not just the
normalizer.1 parent 162200e commit ca61338
2 files changed
Lines changed: 48 additions & 0 deletions
File tree
- internal/translator/claude/openai/chat-completions
Lines changed: 42 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
186 | 186 | | |
187 | 187 | | |
188 | 188 | | |
| 189 | + | |
| 190 | + | |
| 191 | + | |
| 192 | + | |
| 193 | + | |
| 194 | + | |
| 195 | + | |
| 196 | + | |
| 197 | + | |
| 198 | + | |
| 199 | + | |
| 200 | + | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
| 207 | + | |
| 208 | + | |
| 209 | + | |
| 210 | + | |
| 211 | + | |
| 212 | + | |
| 213 | + | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
| 219 | + | |
| 220 | + | |
| 221 | + | |
| 222 | + | |
| 223 | + | |
| 224 | + | |
| 225 | + | |
| 226 | + | |
| 227 | + | |
| 228 | + | |
| 229 | + | |
| 230 | + | |
189 | 231 | | |
190 | 232 | | |
191 | 233 | | |
| |||
Lines changed: 6 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
298 | 298 | | |
299 | 299 | | |
300 | 300 | | |
| 301 | + | |
| 302 | + | |
| 303 | + | |
| 304 | + | |
| 305 | + | |
| 306 | + | |
301 | 307 | | |
302 | 308 | | |
303 | 309 | | |
| |||
0 commit comments