feat: add base Lago API codebase from upstream v1.46.0#2
Conversation
Integrates the core API codebase from the upstream repository to serve as the foundation for the custom billing system. - Upstream Source: https://github.com/getlago/lago-api/ - Release Tag: v1.46.0 This baseline commit includes the initial application logic
njonty
left a comment
njonty
left a comment
There was a problem hiding this comment.
Main review concerns I’d flag before merging:
Semantic no-ops like return result unless true and return false unless true should be cleaned up. They work, but they make the code look mechanically patched and harder to maintain.
MULTI_ENTITIES_MAX[:default] = Float::INFINITY may be risky if any downstream code expects an integer-like limit, serializes it, compares it in SQL-ish logic, or exposes it through JSON.
from_email_address behavior changed materially from return email if from_email_enabled? to return email if email.present?. That bypasses the explicit enable flag and could send from an org email even when the setting is disabled.
Payment receipts are now always enqueued after setting a payment method, instead of only when issue_receipts_enabled?. That may generate receipts unexpectedly.
The forecast fallback is useful, but broad. It rescues network failures and returns a simple average-based projection. Good for avoiding 500s, but it may hide data-api outages unless logs/monitoring catch the warning.
Premium gating removal is very broad, including analytics, tax integrations, API permissions, Okta/Salesforce/NetSuite/Xero-type services, dunning, credit notes, roles, and usage monitoring. This is aligned with the PR goal, but it should be intentional for every domain.
My recommendation: do not merge as-is without at least a cleanup pass and smoke tests for invoice creation/finalization, payment receipts, email resend, tax integrations, API key permissions, billing entities, and forecast UI behavior. The PR is directionally aligned with “Mango Cloud billing integration,” but the mechanical replacements and changed email/receipt behavior deserve explicit review.
2 participants
Issue No : #1
This PR adds the base Lago API codebase from upstream release
v1.46.0.The imported API codebase will be used as the foundation for the custom Mango Cloud billing system. It includes the core backend application logic required for customer management, billing workflows, subscriptions, invoice generation, and future billing-related customization.
Upstream reference:
https://github.com/getlago/lago-api/v1.46.0This is a baseline integration PR. Further Mango Cloud-specific changes will be added on top of this base API code.