Return more information#13
Open
rowanwins wants to merge 1 commit into
Open
Conversation
|
Hey @rowanwins - I'd be really interested in this change. Returning the vertex ID would allow me to fix a common bug in the turf geospatial library's line split function: Turfjs/turf#1232 Currently that function relies on a buggy point-to-line search to find the vertex IDs, when it could be returned from this package instead. I'm not a big fan of options changing the return type of a function, so instead consider a seperate function. I'd suggest the following API: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch explores returning some extra information for intersection points.
As it currently stands this would be a breaking change, although I could possibly expose the info via an option.