Update BUILDING-FEDORA.md#839
Open
samnooij wants to merge 1 commit into
Open
Conversation
I needed to install onnxruntime-devel (and onnxruntime) as well before I got it to work on Fedora 43 (with GNOME).
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Fedora build documentation to reflect an additional dependency required to compile the OBS background removal plugin on newer Fedora releases.
Changes:
- Add
onnxruntime-develto the documenteddnf installdependency list on Fedora.
Comment on lines
20
to
+22
| obs-studio-devel \ | ||
| opencv-devel | ||
| opencv-devel \ | ||
| onnxruntime-devel |
There was a problem hiding this comment.
The PR description says Fedora needed both onnxruntime-devel and onnxruntime, but the updated dependency list only adds onnxruntime-devel. To avoid confusion (and to ensure the runtime library is present if -devel doesn’t pull it in on some Fedora variants), either add onnxruntime here as well or explicitly note that installing onnxruntime-devel will install the runtime package as a dependency.
umireon
added
auto-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed to install onnxruntime-devel (and onnxruntime) as well before I got it to work on Fedora 43 (with GNOME).
Pull Request Checklist
Please read our latest CONTRIBUTING.md.