Disable conversion of HEAD method to GET#89
Open
aspettl wants to merge 1 commit into
Open
Conversation
Author
rpardini
force-pushed
the
disable_convert_head_requests
branch
from
February 23, 2025 23:30
399ccfc to
7b3e99a
Compare
rpardini
previously approved these changes
Feb 23, 2025
rpardini
self-requested a review
July 1, 2026 10:47
rpardini
added
the
outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR disables the conversion of request method HEAD to GET when caching applies. As the documentation at http://nginx.org/en/docs/http/ngx_http_proxy_module.html#proxy_cache_convert_head suggests, the cache key is extended with the method.
In order to not invalidate existing caches, I decided to keep the cache keys for GET as they are. Only HEAD requests will use a "HEAD:" prefix. This could be cleaned up later when a breaking change needs to be made anyway (e.g., why don't we have the FQDN or registry name in the cache key?).