Skip to content

Commit bf632f1

Browse files
committed
Quote cpack_generators correctly so values containing semicolons work
1 parent 4395803 commit bf632f1

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

release-process/test-system.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -172,15 +172,15 @@ def config_script_function(config_key):
172172
config_script_function('setup_commands'),
173173
config_script_function('install_build_deps'),
174174
config_script_function('install_app_test_deps'),
175-
'git_revision=%s'%args.git_revision,
175+
'git_revision="%s"'%args.git_revision,
176176
'staticlibs=%s'%('TRUE' if distro_config.get('staticlibs', True) else 'FALSE'),
177177
'build_dist=%d'%(1 if args.dist_files_dir is not None else 0),
178178
# Firefox doesn't have release tarballs for Aarch64
179179
'test_firefox=%d'%(1 if args.architecture == 'x86_64' else 0),
180180
# libreoffice uses STREX
181181
'test_libreoffice=%d'%(1 if args.architecture == 'x86_64' else 0),
182182
'ctest_options="%s"'%' '.join(c for c in ctest_options),
183-
'cpack_generators=%s'%args.cpack_generators
183+
'cpack_generators="%s"'%args.cpack_generators
184184
]).encode('utf-8') + b'\n' + rr_testing_script
185185
vm.ssh(['/bin/bash', '-s'], full_script)
186186
if args.dist_files_dir is not None:

0 commit comments

Comments
 (0)